controllers: add a new controller to setup mirroring #2878
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci
bot
added
the
do-not-merge/work-in-progress
|
Skipping CI for Draft Pull Request. |
rewantsoni
force-pushed
the
mirroring-controller
branch
from
bc1e147
to
8b1f059
Compare
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: rewantsoni The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
rewantsoni
force-pushed
the
mirroring-controller
branch
3 times, most recently
from
1128536
to
4d36986
Compare
openshift-merge-robot
added
the
needs-rebase
rewantsoni
force-pushed
the
mirroring-controller
branch
from
4d36986
to
e3e601b
Compare
openshift-merge-robot
removed
the
needs-rebase
openshift-ci
bot
removed
the
do-not-merge/work-in-progress
openshift-merge-robot
added
the
needs-rebase
rewantsoni
force-pushed
the
mirroring-controller
branch
from
e3e601b
to
451b704
Compare
openshift-merge-robot
removed
the
needs-rebase
rewantsoni
force-pushed
the
mirroring-controller
branch
3 times, most recently
from
2c252fc
to
64ce4ce
Compare
openshift-merge-robot
added
the
needs-rebase
rewantsoni
force-pushed
the
mirroring-controller
branch
from
64ce4ce
to
f5d610d
Compare
openshift-merge-robot
removed
the
needs-rebase
Signed-off-by: Rewant Soni <[email protected]> add generated changes Signed-off-by: Rewant Soni <[email protected]>
Signed-off-by: Rewant Soni <[email protected]> add generated changes Signed-off-by: Rewant Soni <[email protected]>
Signed-off-by: Rewant Soni <[email protected]> add generated changes Signed-off-by: Rewant Soni <[email protected]>
rewantsoni
force-pushed
the
mirroring-controller
branch
from
f5d610d
to
0c6cd48
Compare
Signed-off-by: Rewant Soni <[email protected]>
rewantsoni
force-pushed
the
mirroring-controller
branch
from
0c6cd48
to
8cf94cb
Compare
umangachapagain
requested changes
Nov 14, 2024
|
|
||
| if err = r.get(r.clientMappingConfig); err != nil { | ||
| if k8serrors.IsNotFound(err) { | ||
| r.log.Info(fmt.Sprintf("ConfigMap %s not found. Ignoring since object must be deleted.", r.clientMappingConfig.Name)) |
There was a problem hiding this comment.
Do not use sprintf when logging. Use key-value pairs instead.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A new controller to enable mirroring for cephblockpool and radosnamespace
Depends On: