Skip to content

controllers: send the client profile mapping required for DR #2879

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 19, 2024

Conversation

rewantsoni
Copy link
Member

@rewantsoni rewantsoni commented Nov 7, 2024

This mapping is sent only if rns is enabled for mirroring

  • remote poolID is fetched from GetBlockPoolInfo rpc, which is then written to a blockpool as an annotation to be read by provider server
  • local poolID is fetched from cephBlockPool status

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 7, 2024
Copy link
Contributor

openshift-ci bot commented Nov 7, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@rewantsoni rewantsoni force-pushed the clientProfile branch 3 times, most recently from 350e6bf to fbc1c87 Compare November 9, 2024 17:59
@rewantsoni rewantsoni marked this pull request as ready for review November 9, 2024 18:00
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 9, 2024
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 13, 2024
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 14, 2024
@rewantsoni rewantsoni force-pushed the clientProfile branch 6 times, most recently from a8f4689 to 9962e26 Compare November 18, 2024 12:57
@rewantsoni rewantsoni force-pushed the clientProfile branch 4 times, most recently from 6e01d93 to fc7ac51 Compare November 19, 2024 17:07
@nb-ohad
Copy link
Contributor

nb-ohad commented Nov 19, 2024

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 19, 2024
Copy link
Contributor

openshift-ci bot commented Nov 19, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nb-ohad, rewantsoni

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 19, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit 84da605 into red-hat-storage:main Nov 19, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants