Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

saving quota in GiB instead GB #2895

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

saving quota in GiB instead GB #2895

wants to merge 1 commit into from
+10 −8

Conversation

rchikatw
Copy link
Contributor

@rchikatw rchikatw commented Nov 13, 2024 •
edited
Loading

@rchikatw
Copy link
Contributor Author

@nb-ohad @leelavg please review

leelavg
leelavg reviewed Nov 14, 2024
View reviewed changes
services/provider/server/server.go Outdated
int64(consumerResource.Spec.StorageQuotaInGiB),
resource.Giga,
Hard: corev1.ResourceList{"requests.storage": *resource.NewQuantity(
int64(consumerResource.Spec.StorageQuotaInGiB*1024*1024*1024),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reading only this line seems a bit confusing, did it occur to you that if only this line is read, it feels like we are multiplying a value which has GiB in it's name by 1024^3 resulting in something like Exbibyte?

maybe it only occurred to me, since the conversion is correct, approving it.

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 14, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Nov 14, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: leelavg, rchikatw
Once this PR has been reviewed and has the lgtm label, please assign obnoxxx for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Nov 14, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Nov 14, 2024

New changes are detected. LGTM label has been removed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leelavg leelavg leelavg approved these changes

At least 2 approving reviews are required to merge this pull request.

Assignees

@leelavg leelavg

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rchikatw @leelavg