-
Notifications
You must be signed in to change notification settings - Fork 184
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update ocs-operator direct dependencies #2896
base: main
Are you sure you want to change the base?
Conversation
8e8fdce
to
640355b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pls confirm if 1.22.9 is available DS with @b-ranto and remove the hold
/hold
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: iamniting, malayparida2000 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/test ocs-operator-bundle-e2e-aws |
1 similar comment
/test ocs-operator-bundle-e2e-aws |
@iamniting The failure is genuine
|
seems openshift-ci env has locally go 1.22.7 installed. |
Signed-off-by: Malay Kumar Parida <[email protected]>
Signed-off-by: Malay Kumar Parida <[email protected]>
New changes are detected. LGTM label has been removed. |
@@ -1,18 +1,18 @@ | |||
module github.com/red-hat-storage/ocs-operator/api/v4 | |||
|
|||
go 1.22.0 | |||
go 1.22.7 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we avoid locking this to a specific z-release? Can we just keep it 1.22.0
? Toolchain version can be 1.22.7
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@umangachapagain is there a reason for that?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That'd allow me to use any 1.22.z instead of forcing me to a specific version ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sticking to go 1.22.0 may open us up to potential CVEs, and I have confirmed with the Build team and Go 1.22.7 is the latest available version in their environment & it's the latest available in openshift CI env as well. So I see no harm in using that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That'd allow me to use any 1.22.z instead of forcing me to a specific version ?
I think by that you meant specifying only 1.22 not 1.22.0? If we specify just 1.22 it will pull 1.22.9 which is not available in Builder images so it will cause issue in openshift-ci as well as build environment.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This just defines the minimal version, it is fine to use it like that, especially if you also set the toolchain
directive to a more current version which defines the recommended version. This should not really be blocking people from compiling the code on go versions that do have some CVEs in them.
No description provided.