Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ocs-operator direct dependencies #2896

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

malayparida2000
Copy link
Contributor

No description provided.

Copy link
Member

@iamniting iamniting left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pls confirm if 1.22.9 is available DS with @b-ranto and remove the hold

/hold

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 13, 2024
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 13, 2024
Copy link
Contributor

openshift-ci bot commented Nov 13, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: iamniting, malayparida2000

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 13, 2024
@iamniting
Copy link
Member

/test ocs-operator-bundle-e2e-aws

1 similar comment
@iamniting
Copy link
Member

/test ocs-operator-bundle-e2e-aws

@malayparida2000
Copy link
Contributor Author

@iamniting The failure is genuine

hack/build-functest.sh
Installing GINKGO binary at /go/src/github.com/red-hat-storage/ocs-operator/bin/ginkgo
go: go.mod requires go >= 1.22.9 (running go 1.22.7; GOTOOLCHAIN=local)
make: *** [Makefile:105: build-functest] Error 1
{"component":"entrypoint","error":"wrapped process failed: exit status 2","file":"sigs.k8s.io/prow/pkg/entrypoint/run.go:84","func":"sigs.k8s.io/prow/pkg/entrypoint.Options.internalRun","level":"error","msg":"Error executing test process","severity":"error","time":"2024-11-13T18:37:58Z"}

@malayparida2000
Copy link
Contributor Author

malayparida2000 commented Nov 14, 2024

@iamniting The failure is genuine

hack/build-functest.sh
Installing GINKGO binary at /go/src/github.com/red-hat-storage/ocs-operator/bin/ginkgo
go: go.mod requires go >= 1.22.9 (running go 1.22.7; GOTOOLCHAIN=local)
make: *** [Makefile:105: build-functest] Error 1
{"component":"entrypoint","error":"wrapped process failed: exit status 2","file":"sigs.k8s.io/prow/pkg/entrypoint/run.go:84","func":"sigs.k8s.io/prow/pkg/entrypoint.Options.internalRun","level":"error","msg":"Error executing test process","severity":"error","time":"2024-11-13T18:37:58Z"}

seems openshift-ci env has locally go 1.22.7 installed.

Copy link
Contributor

openshift-ci bot commented Nov 14, 2024

New changes are detected. LGTM label has been removed.

@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Nov 14, 2024
@@ -1,18 +1,18 @@
module github.com/red-hat-storage/ocs-operator/api/v4

go 1.22.0
go 1.22.7
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we avoid locking this to a specific z-release? Can we just keep it 1.22.0 ? Toolchain version can be 1.22.7.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@umangachapagain is there a reason for that?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That'd allow me to use any 1.22.z instead of forcing me to a specific version ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sticking to go 1.22.0 may open us up to potential CVEs, and I have confirmed with the Build team and Go 1.22.7 is the latest available version in their environment & it's the latest available in openshift CI env as well. So I see no harm in using that.

Copy link
Contributor Author

@malayparida2000 malayparida2000 Nov 14, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That'd allow me to use any 1.22.z instead of forcing me to a specific version ?

I think by that you meant specifying only 1.22 not 1.22.0? If we specify just 1.22 it will pull 1.22.9 which is not available in Builder images so it will cause issue in openshift-ci as well as build environment.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This just defines the minimal version, it is fine to use it like that, especially if you also set the toolchain directive to a more current version which defines the recommended version. This should not really be blocking people from compiling the code on go versions that do have some CVEs in them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants