add private volumeGroupSnapshotClass Api

[ShravaniVangur]

Updating the ocs-operator to import the private volumegroupsnapshotclass api,enabling access to and utilization of the private fork of the sidecar available at https://github.com/red-hat-storage/external-snapshotter.

VolumeGroupSnapshotClass Creation PR: Ocs-Client-Operator

Result:

NAME                                       DRIVER                                  DELETIONPOLICY   AGE
ocs-storagecluster-cephfs-groupsnapclass   [openshift-storage.cephfs.csi.ceph.com](http://openshift-storage.cephfs.csi.ceph.com/)   Delete           13s

With featuregate enabled:

oc get volumegroupsnapshotclass.groupsnapshot.storage.openshift.io
NAME                                       DRIVER                                  DELETIONPOLICY   AGE
ocs-storagecluster-cephfs-groupsnapclass   openshift-storage.cephfs.csi.ceph.com   Delete           12m

oc get volumegroupsnapshotclass.groupsnapshot.storage.k8s.io      
NAME                                         DRIVER                                  DELETIONPOLICY   AGE
ocs-storagecluster-ceph-rbd-groupsnapclass   openshift-storage.rbd.csi.ceph.com      Delete           80s
ocs-storagecluster-cephfs-groupsnapclass     openshift-storage.cephfs.csi.ceph.com   Delete           80s

Name:             ocs-storagecluster-cephfs-groupsnapclass
Namespace:
Labels:           [ramendr.openshift.io/storageid=4b6a45a67974c61dea673244ea12f915](http://ramendr.openshift.io/storageid=4b6a45a67974c61dea673244ea12f915)
Annotations:      <none>
API Version:      [groupsnapshot.storage.openshift.io/v1beta1](http://groupsnapshot.storage.openshift.io/v1beta1)
Deletion Policy:  Delete
Driver:           [openshift-storage.cephfs.csi.ceph.com](http://openshift-storage.cephfs.csi.ceph.com/)
Kind:             VolumeGroupSnapshotClass
Metadata:
  Creation Timestamp:  2025-06-16T18:12:03Z
  Generation:          1
  Owner References:
    API Version:           [ocs.openshift.io/v1alpha1](http://ocs.openshift.io/v1alpha1)
    Block Owner Deletion:  true
    Controller:            true
    Kind:                  StorageClient
    Name:                  ocs-storagecluster
    UID:                   55c8cd31-df79-4193-91c1-6b818a08e979
  Resource Version:        463031
  UID:                     469c1d49-b433-4275-842c-bf75f86db3ff
Parameters:
  Cluster ID:                                             openshift-storage
  [csi.storage.k8s.io/group-snapshotter-secret-name](http://csi.storage.k8s.io/group-snapshotter-secret-name):       cephfs-provisioner-1b5eca0f-5ab0-4272-bd1a-3c83536dfeee
  [csi.storage.k8s.io/group-snapshotter-secret-namespace](http://csi.storage.k8s.io/group-snapshotter-secret-namespace):  openshift-storage
  Fs Name:                                                ocs-storagecluster-cephfilesystem
Events:                                                   <none>

[openshift-ci]

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

[ShravaniVangur]

/hold For testing

[ShravaniVangur]

/unhold

[iamniting]

The second commit is not about the vendor changes only, It is about all generated changes. I would like to see them separate if possible.

[rewantsoni]

Maybe we should have the whole class display name here?volumegroupsnapshotclass.groupsnapshot.storage.openshift.io.

[rewantsoni]

I think we are using this only once, we can hardcode it

[leelavg]

as controllers/storagecluster/odfvolumegroupsnapshotterclasses.go is copy of existing similar code not leaving comments on that to behave the same way of public vgsc reconciliation.

[leelavg]

@ShravaniVangur there is a actual test failure in CI, ptal.

[ShravaniVangur]

/test ocs-operator-bundle-e2e-aws

[leelavg]

based on offline discussion, below is the required fix

diff --git a/services/provider/server/server.go b/services/provider/server/server.go
index f1bdf9c6c..744bd17b9 100644
--- a/services/provider/server/server.go
+++ b/services/provider/server/server.go
@@ -2079,7 +2079,7 @@ func getKubeResourcesForClass[T CommonClassSpecAccessors](
                klog.Warningf("Encountered unsupported provisioner in %s: %s", classDisplayName, srcName)
            } else if errors.Is(err, util.UnsupportedDriver) {
                klog.Warningf("Encountered unsupported driver in %s: %s", classDisplayName, srcName)
-           } else if srcKubeObj == nil {
+           } else if reflect.ValueOf(srcKubeObj).IsNil() {
                klog.Warningf("The name %s does not points to a builtin or an existing %s, skipping", classDisplayName, srcName)
            } else if srcKubeObj.GetLabels()[util.ExternalClassLabelKey] == "true" {
                klog.Warningf("The %s is an external %s, skipping", srcName, classDisplayName)
@@ -2087,7 +2087,7 @@ func getKubeResourcesForClass[T CommonClassSpecAccessors](
                srcClassCache[srcName] = srcKubeObj
            }
        }
-       if srcKubeObj != nil {
+       if _, exist := srcClassCache[srcName]; exist {
            distKubeObj := srcKubeObj.DeepCopyObject().(client.Object)
            distKubeObj.SetName(destName)
            kubeResources = append(kubeResources, distKubeObj)

RC is very well explained in https://www.jerf.org/iri/post/2957/

"a nil interface" and "an interface containing nil" are not the same nil. One nil is of the interface's type, and the other nil is contained in the interface but has a specific other type that is not the interface.

[leelavg]

/lgtm

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: iamniting, leelavg, ShravaniVangur

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [iamniting]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment