Skip to content

storageclasses: automate key rotation for encrypted RBD storageclasses #3302

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

black-dragon74
Copy link
Member

This patch sets the key rotation annotation by default on encrypted RBD storageclasses.

This patch sets the key rotation annotation by default on encrypted
RBD storageclasses.

Signed-off-by: Niraj Yadav <[email protected]>
Copy link
Member

@Madhu-1 Madhu-1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 7, 2025
@rewantsoni
Copy link
Member

@black-dragon74 What about the day2 storageClass created by the user, will they be responsible for adding the key rotation annotation?

@black-dragon74
Copy link
Member Author

@black-dragon74 What about the day2 storageClass created by the user, will they be responsible for adding the key rotation annotation?

Yes. This is only for the storageclasses that we create.

@black-dragon74
Copy link
Member Author

@leelavg @rewantsoni PTAL. Requires one more ✅

Copy link
Contributor

openshift-ci bot commented Jul 17, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: black-dragon74, leelavg, Madhu-1
Once this PR has been reviewed and has the lgtm label, please assign jarrpa for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants