Skip to content

indicate connected client about server ability to serve requests #3386

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 23, 2025

Conversation

leelavg
Copy link
Contributor

@leelavg leelavg commented Jul 23, 2025

  1. explicitly sets a key on client-op configmap for client to take decisions on co-location with hub
  2. explicity send a failed precondition when server not able to serve the connected client

@leelavg
Copy link
Contributor Author

leelavg commented Jul 23, 2025

/cherrypick release-4.19
via DFBUGS-3664

@openshift-cherrypick-robot
Copy link

openshift-cherrypick-robot commented Jul 23, 2025

@leelavg: once the present PR merges, I will cherry-pick it on top of release-4.19 in a new PR and assign it to you.

In response to this:

/cherrypick release-4.19
via DFBUGS-3664

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@leelavg leelavg force-pushed the newer-client branch 2 times, most recently from dc88eb7 to 93dd507 Compare July 23, 2025 11:19
@leelavg leelavg force-pushed the newer-client branch 2 times, most recently from 28ed486 to f360a79 Compare July 23, 2025 12:08
1. explicitly sets a key on client-op configmap for client to take
decisions on co-location with hub
2. explicity send a failed precondition when server not able to serve
the connected client

Signed-off-by: Leela Venkaiah G <[email protected]>
@nb-ohad
Copy link
Contributor

nb-ohad commented Jul 23, 2025

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 23, 2025
Copy link
Contributor

openshift-ci bot commented Jul 23, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: leelavg, nb-ohad

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 23, 2025
@openshift-merge-bot openshift-merge-bot bot merged commit bf410db into red-hat-storage:main Jul 23, 2025
16 of 17 checks passed
@openshift-cherrypick-robot

@leelavg: new pull request created: #3388

In response to this:

/cherrypick release-4.19
via DFBUGS-3664

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants