Skip to content

Remove deprecated fields from storagecluster & ocsinitialization types#3387

Merged
openshift-merge-bot[bot] merged 4 commits intored-hat-storage:mainfrom
malayparida2000:deprecated_apis
Jul 24, 2025
Merged

Remove deprecated fields from storagecluster & ocsinitialization types#3387
openshift-merge-bot[bot] merged 4 commits intored-hat-storage:mainfrom
malayparida2000:deprecated_apis

Conversation

@malayparida2000
Copy link
Contributor

@malayparida2000 malayparida2000 commented Jul 23, 2025

These fields have been lying around without usage since very long, we should now get rid of them.

@malayparida2000
Copy link
Contributor Author

Just for reference if we were using any of these removed fields anywhere in our code, Our code would not have compiled & would have faced CI failures.

@malayparida2000 malayparida2000 requested a review from nb-ohad July 24, 2025 03:52
@malayparida2000
Copy link
Contributor Author

/cc @nb-ohad
/cc @iamniting

@openshift-ci openshift-ci bot requested a review from iamniting July 24, 2025 03:53
@rewantsoni
Copy link
Member

We should probably move the NewToolsDeployment from storagecluster types to cephtoolbox.go

@malayparida2000
Copy link
Contributor Author

We should probably move the NewToolsDeployment from storagecluster types to cephtoolbox.go

Yeah, right, but Want to keep this PR's scope only to the removal of unused fields.

@leelavg
Copy link
Contributor

leelavg commented Jul 24, 2025

LGTM.

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 24, 2025
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 24, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: iamniting, malayparida2000

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 24, 2025
@openshift-merge-bot openshift-merge-bot bot merged commit fdf0aec into red-hat-storage:main Jul 24, 2025
11 checks passed
@malayparida2000 malayparida2000 deleted the deprecated_apis branch March 20, 2026 05:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants