-
Notifications
You must be signed in to change notification settings - Fork 185
Remove deprecated fields from storagecluster & ocsinitialization types #3387
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove deprecated fields from storagecluster & ocsinitialization types #3387
Conversation
Signed-off-by: Malay Kumar Parida <[email protected]>
Signed-off-by: Malay Kumar Parida <[email protected]>
Signed-off-by: Malay Kumar Parida <[email protected]>
Signed-off-by: Malay Kumar Parida <[email protected]>
Just for reference if we were using any of these removed fields anywhere in our code, Our code would not have compiled & would have faced CI failures. |
/cc @nb-ohad |
We should probably move the NewToolsDeployment from storagecluster types to cephtoolbox.go |
Yeah, right, but Want to keep this PR's scope only to the removal of unused fields. |
LGTM. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: iamniting, malayparida2000 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
fdf0aec
into
red-hat-storage:main
These fields have been lying around without usage since very long, we should now get rid of them.