Fix the kebab menu close when we click outside the kebab. #1595
Conversation
TimothyAsirJeyasing
force-pushed
the
fix-kabab-close-when-click-outside-bz2308314
branch
from
8bfe4dc
to
ef4adc5
Compare
|
LGTM. @SanjalKatiyar for tagging. |
1 similar comment
|
LGTM. @SanjalKatiyar for tagging. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bipuladh, TimothyAsirJeyasing The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/lgtm cancel |
packages/shared/src/kebab/kebab.tsx
Outdated
|
|
||
| const { resourceModel, resource } = extraProps; | ||
| // Use the custom hook to detect clicks outside the Kebab menu | ||
| useClickOutside(dropdownRef, () => setOpen(false)); |
There was a problem hiding this comment.
u are passing callback () => setOpen(false) to dep list of useEffect inside useClickOutside hook, but ref of this callback is changing on each re-render.
There was a problem hiding this comment.
wrap it around useCallback plz...
|
@TimothyAsirJeyasing plz add corresponding Jira BZ link to this PR... |
|
@TimothyAsirJeyasing please rebase & solve conflicts. |
BZ: https://bugzilla.redhat.com/show_bug.cgi?id=2308314 Jira: https://issues.redhat.com/browse/DFBUGS-351 Signed-off-by: Timothy Asir Jeyasingh <[email protected]>
TimothyAsirJeyasing
force-pushed
the
fix-kabab-close-when-click-outside-bz2308314
branch
from
ef4adc5
to
54ce4b0
Compare
BZ: https://bugzilla.redhat.com/show_bug.cgi?id=2308314
https://issues.redhat.com/browse/DFBUGS-351