Fixes cypress tests #2160
Fixes cypress tests #2160
Conversation
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bipuladh The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/test odf-console-e2e-aws |
bipuladh
force-pushed
the
fix-tests
branch
9 times, most recently
from
9b6eed3 to
8bf8c2c
Compare
|
/retest |
2 similar comments
|
/retest |
|
/retest |
bipuladh
force-pushed
the
fix-tests
branch
3 times, most recently
from
d73b3a6 to
77e1fac
Compare
Signed-off-by: Bipul Adhikari <[email protected]>
| @@ -116,6 +116,7 @@ const InitialEmptyStatePage: React.FC = () => { | |||
| <EmptyStateFooter> | |||
| <EmptyStateActions> | |||
| <Button | |||
| data-test="configure-data-foundation" | |||
There was a problem hiding this comment.
Just an observation for follow-up PRs: the recommended approach is to use a11y selectors instead of data-test: https://docs.cypress.io/app/guides/accessibility-testing
| @@ -294,7 +296,7 @@ export const Kebab: React.FC<KebabProps> & KebabStaticProperties = ({ | |||
| } | |||
| > | |||
| <Dropdown | |||
| data-test="kebab-button" | |||
| data-test={dataTestId ?? 'kebab-button'} | |||
There was a problem hiding this comment.
Nullish coalescing operator only checks null or undefined, but dataTestId could also be an empty string or similar falsy value:
| data-test={dataTestId ?? 'kebab-button'} | |
| data-test={dataTestId || 'kebab-button'} |
There was a problem hiding this comment.
is someone wants to purposefully disable it by passing an empty string we should allow it.
There was a problem hiding this comment.
What is the purpose of passing a data-test empty value? It doesn't make any sense to me.
data-test should always have a value.
|
@bipuladh: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Fixes: https://issues.redhat.com/browse/RHSTOR-7230