Bug 2242324: exporter: fetch performance metrics from prometheus exporter for 4.13 #563

avanthakkar · 2024-02-01T08:24:22Z

Enable functionality for fetching performance counters of ceph daemons in prometheus module by setting exclude_perf_counters to false

Description of your changes:

Which issue is resolved by this Pull Request:
Resolves #

Checklist:

Commit Message Formatting: Commit titles and messages follow guidelines in the developer guide).
Skip Tests for Docs: If this is only a documentation change, add the label skip-ci on the PR.
Reviewed the developer guide on Submitting a Pull Request
Pending release notes updated with breaking and/or notable changes for the next minor release.
Documentation has been updated, if necessary.
Unit tests have been added, if necessary.
Integration tests have been added, if necessary.

openshift-ci · 2024-02-01T08:24:27Z

@avanthakkar: This pull request references Bugzilla bug 2242324, which is invalid:

expected the bug to target the "ODF 4.13.7" release, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

rkachach · 2024-02-01T10:09:11Z

pkg/operator/ceph/cluster/mgr/mgr.go

+	// Fetch performance counters from the prometheus exporter as ceph-exporter is disabled for 4.13
+	err = monStore.Set("mgr", "mgr/prometheus/exclude_perf_counters", false)
+	if err != nil {
+		return errors.Wrapf(err, "failed to enable exclude_perf_counters")


nit: the err message must be failed to disable in this case or more dev/debug friendly something like "failed to enable prometheus mgr module perf counters"

Okay, but I feel like this message is more about the module option enabling/disabling

openshift-ci · 2024-02-01T10:09:20Z

@rkachach: changing LGTM is restricted to collaborators

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

travisn · 2024-02-01T16:40:32Z

pkg/operator/ceph/cluster/mgr/mgr.go

@@ -205,6 +205,13 @@ func (c *Cluster) Start() error {

 	// configure the mgr modules
 	c.configureModules(daemonIDs)
+
+	// Fetch performance counters from the prometheus exporter as ceph-exporter is disabled for 4.13
+	monStore := config.GetMonStore(c.context, c.clusterInfo)


Could you put this inside the method configurePrometheusModule() to be consistent with #564?

I coulnd't find such function for 4.13. I only see configureModules()

I see it changed in 4.14, how about in enablePrometheusModule() for 4.13?

Enable functionality for fetching performance counters of ceph daemons in prometheus module by setting `exclude_perf_counters` to false Signed-off-by: Avan Thakkar <[email protected]>

travisn

LGTM, it's just a known CI issue we are working on with rook#13675

openshift-ci · 2024-02-02T17:39:29Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: avanthakkar, travisn

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [travisn]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-bot · 2024-02-03T01:00:46Z

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

openshift-ci · 2024-02-03T01:00:51Z

@openshift-bot: This pull request references Bugzilla bug 2242324, which is invalid:

expected the bug to target the "ODF 4.13.7" release, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-bot · 2024-02-04T01:00:46Z

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

openshift-ci · 2024-02-04T01:00:50Z

@openshift-bot: This pull request references Bugzilla bug 2242324, which is invalid:

expected the bug to target the "ODF 4.13.7" release, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-bot · 2024-02-05T01:00:49Z

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

openshift-ci · 2024-02-05T01:00:54Z

@openshift-bot: This pull request references Bugzilla bug 2242324, which is invalid:

expected the bug to target the "ODF 4.13.7" release, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-bot · 2024-02-06T01:00:25Z

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

openshift-ci · 2024-02-06T01:00:30Z

@openshift-bot: This pull request references Bugzilla bug 2242324, which is invalid:

expected the bug to target the "ODF 4.13.7" release, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-bot · 2024-02-07T01:00:26Z

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

openshift-ci · 2024-02-07T01:00:53Z

@openshift-bot: This pull request references Bugzilla bug 2242324, which is invalid:

expected the bug to target the "ODF 4.13.7" release, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-bot · 2024-02-08T01:00:33Z

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

openshift-ci · 2024-02-11T01:00:41Z

@openshift-bot: This pull request references Bugzilla bug 2242324, which is invalid:

expected the bug to target the "ODF 4.13.8" release, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-bot · 2024-02-12T01:00:58Z

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

openshift-ci · 2024-02-12T01:01:02Z

@openshift-bot: This pull request references Bugzilla bug 2242324, which is invalid:

expected the bug to target the "ODF 4.13.8" release, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-bot · 2024-02-13T01:00:14Z

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

openshift-ci · 2024-02-13T01:00:20Z

@openshift-bot: This pull request references Bugzilla bug 2242324, which is invalid:

expected the bug to target the "ODF 4.13.8" release, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-bot · 2024-02-14T01:00:21Z

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

openshift-ci · 2024-02-14T01:00:52Z

@openshift-bot: This pull request references Bugzilla bug 2242324, which is invalid:

expected the bug to target the "ODF 4.13.8" release, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-bot · 2024-02-15T01:00:40Z

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

openshift-ci · 2024-02-15T01:01:31Z

@openshift-bot: This pull request references Bugzilla bug 2242324, which is invalid:

expected the bug to target the "ODF 4.13.8" release, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-bot · 2024-02-16T01:01:03Z

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

openshift-ci · 2024-02-16T01:01:42Z

@openshift-bot: This pull request references Bugzilla bug 2242324, which is invalid:

expected the bug to target the "ODF 4.13.8" release, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-bot · 2024-02-17T01:00:17Z

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

openshift-ci · 2024-02-17T01:00:24Z

@openshift-bot: This pull request references Bugzilla bug 2242324, which is invalid:

expected the bug to target the "ODF 4.13.8" release, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-bot · 2024-02-18T01:00:19Z

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

openshift-ci · 2024-02-18T01:00:24Z

@openshift-bot: This pull request references Bugzilla bug 2242324, which is invalid:

expected the bug to target the "ODF 4.13.8" release, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-bot · 2024-02-19T01:00:19Z

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

openshift-ci · 2024-02-19T01:00:24Z

@openshift-bot: This pull request references Bugzilla bug 2242324, which is invalid:

expected the bug to target the "ODF 4.13.8" release, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-bot · 2024-02-20T01:00:36Z

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

openshift-ci · 2024-02-20T01:01:28Z

@openshift-bot: This pull request references Bugzilla bug 2242324, which is invalid:

expected the bug to target the "ODF 4.13.8" release, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-bot · 2024-02-21T01:00:39Z

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

openshift-ci · 2024-02-21T01:00:43Z

@openshift-bot: This pull request references Bugzilla bug 2242324, which is invalid:

expected the bug to target the "ODF 4.13.8" release, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-bot · 2024-02-22T01:00:44Z

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

openshift-ci · 2024-02-22T01:00:49Z

@openshift-bot: This pull request references Bugzilla bug 2242324, which is invalid:

expected the bug to target the "ODF 4.13.8" release, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-bot · 2024-02-23T01:00:20Z

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

openshift-ci · 2024-02-23T01:00:28Z

@openshift-bot: This pull request references Bugzilla bug 2242324, which is valid.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target release (ODF 4.13.8) matches configured target release for branch (ODF 4.13.8)
bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @nehaberry

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci · 2024-02-23T01:01:03Z

@openshift-ci[bot]: GitHub didn't allow me to request PR reviews from the following users: nehaberry.

Note that only red-hat-storage members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci · 2024-02-28T15:21:14Z

@avanthakkar: Some pull requests linked via external trackers have merged:

The following pull requests linked via external trackers have not merged:

red-hat-storage/rook#564 is open

These pull request must merge or be unlinked from the Bugzilla bug in order for it to move to the next state. Once unlinked, request a bug refresh with /bugzilla refresh.

Bugzilla bug 2242324 has not been moved to the MODIFIED state.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci bot added the bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. label Feb 1, 2024

openshift-ci bot added the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Feb 1, 2024

rkachach suggested changes Feb 1, 2024

View reviewed changes

avanthakkar force-pushed the enable-perf-counters-prometheus branch 2 times, most recently from f79d538 to c5b2662 Compare February 1, 2024 14:29

avanthakkar changed the title ~~Bug 2242324: fetch performance metrics from prometheus exporter for 4.13~~ Bug 2242324: exporter: fetch performance metrics from prometheus exporter for 4.13 Feb 1, 2024

avanthakkar force-pushed the enable-perf-counters-prometheus branch from c5b2662 to ff83c70 Compare February 1, 2024 15:15

travisn requested changes Feb 1, 2024

View reviewed changes

openshift-ci bot assigned travisn Feb 1, 2024

avanthakkar force-pushed the enable-perf-counters-prometheus branch from ff83c70 to e0ab2e5 Compare February 2, 2024 08:14

monitoring: fetch performance metrics from prometheus exporter for 4.13

908771d

Enable functionality for fetching performance counters of ceph daemons in prometheus module by setting `exclude_perf_counters` to false Signed-off-by: Avan Thakkar <[email protected]>

avanthakkar force-pushed the enable-perf-counters-prometheus branch from e0ab2e5 to 908771d Compare February 2, 2024 08:17

avanthakkar requested a review from travisn February 2, 2024 08:17

travisn approved these changes Feb 2, 2024

View reviewed changes

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 2, 2024

openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 2, 2024

openshift-ci bot added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Feb 23, 2024

travisn merged commit 7fddee9 into red-hat-storage:release-4.13 Feb 28, 2024
15 of 47 checks passed

Bug 2242324: exporter: fetch performance metrics from prometheus exporter for 4.13 #563

Bug 2242324: exporter: fetch performance metrics from prometheus exporter for 4.13 #563

Conversation

avanthakkar commented Feb 1, 2024

openshift-ci bot commented Feb 1, 2024

rkachach Feb 1, 2024

Choose a reason for hiding this comment

avanthakkar Feb 1, 2024

Choose a reason for hiding this comment

openshift-ci bot commented Feb 1, 2024

travisn Feb 1, 2024

Choose a reason for hiding this comment

avanthakkar Feb 1, 2024

Choose a reason for hiding this comment

travisn Feb 1, 2024

Choose a reason for hiding this comment

avanthakkar Feb 2, 2024

Choose a reason for hiding this comment

travisn left a comment

Choose a reason for hiding this comment

openshift-ci bot commented Feb 2, 2024

openshift-bot commented Feb 3, 2024

openshift-ci bot commented Feb 3, 2024

openshift-bot commented Feb 4, 2024

openshift-ci bot commented Feb 4, 2024

openshift-bot commented Feb 5, 2024

openshift-ci bot commented Feb 5, 2024

openshift-bot commented Feb 6, 2024

openshift-ci bot commented Feb 6, 2024

openshift-bot commented Feb 7, 2024

openshift-ci bot commented Feb 7, 2024

openshift-bot commented Feb 8, 2024

openshift-ci bot commented Feb 11, 2024

openshift-bot commented Feb 12, 2024

openshift-ci bot commented Feb 12, 2024

openshift-bot commented Feb 13, 2024

openshift-ci bot commented Feb 13, 2024

openshift-bot commented Feb 14, 2024

openshift-ci bot commented Feb 14, 2024

openshift-bot commented Feb 15, 2024

openshift-ci bot commented Feb 15, 2024

openshift-bot commented Feb 16, 2024

openshift-ci bot commented Feb 16, 2024

openshift-bot commented Feb 17, 2024

openshift-ci bot commented Feb 17, 2024

openshift-bot commented Feb 18, 2024

openshift-ci bot commented Feb 18, 2024

openshift-bot commented Feb 19, 2024

openshift-ci bot commented Feb 19, 2024

openshift-bot commented Feb 20, 2024

openshift-ci bot commented Feb 20, 2024

openshift-bot commented Feb 21, 2024

openshift-ci bot commented Feb 21, 2024

openshift-bot commented Feb 22, 2024

openshift-ci bot commented Feb 22, 2024

openshift-bot commented Feb 23, 2024

openshift-ci bot commented Feb 23, 2024

openshift-ci bot commented Feb 23, 2024

openshift-ci bot commented Feb 28, 2024