Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 2295778: osd: allow the AllowOsdCrushWeightUpdate flag always true #716

Merged

Conversation

parth-gr
Copy link
Member

@parth-gr parth-gr commented Sep 3, 2024

This flag is turned on specially for downstream for 4.16

Checklist:

  • Commit Message Formatting: Commit titles and messages follow guidelines in the developer guide.
  • Reviewed the developer guide on Submitting a Pull Request
  • Pending release notes updated with breaking and/or notable changes for the next minor release.
  • Documentation has been updated, if necessary.
  • Unit tests have been added, if necessary.
  • Integration tests have been added, if necessary.

@openshift-ci openshift-ci bot added bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Sep 3, 2024
Copy link

openshift-ci bot commented Sep 3, 2024

@parth-gr: This pull request references Bugzilla bug 2295778, which is invalid:

  • expected the bug to be in one of the following states: NEW, ASSIGNED, ON_DEV, POST, POST, but it is MODIFIED instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 2295778: osd: allow the AllowOsdCrushWeightUpdate flag always true

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@parth-gr
Copy link
Member Author

parth-gr commented Sep 3, 2024

/assign @travisn

@parth-gr
Copy link
Member Author

parth-gr commented Sep 3, 2024

/assign @subhamkrai

@travisn
Copy link

travisn commented Sep 3, 2024

/approve
/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 3, 2024
Copy link

openshift-ci bot commented Sep 3, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: parth-gr, travisn

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@parth-gr
Copy link
Member Author

parth-gr commented Sep 3, 2024

@travisn seems like test failing are un releated to mine changes, we need to separately fix the ci.

@agarwal-mudit
Copy link
Member

/bugzilla refresh

@openshift-ci openshift-ci bot added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Sep 3, 2024
Copy link

openshift-ci bot commented Sep 3, 2024

@agarwal-mudit: This pull request references Bugzilla bug 2295778, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (ODF 4.16.2) matches configured target release for branch (ODF 4.16.2)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

No GitHub users were found matching the public email listed for the QA contact in Bugzilla ([email protected]), skipping review request.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@travisn travisn merged commit 2cd7c35 into red-hat-storage:release-4.16 Sep 3, 2024
43 of 49 checks passed
Copy link

openshift-ci bot commented Sep 3, 2024

@parth-gr: All pull requests linked via external trackers have merged:

Bugzilla bug 2295778 has been moved to the MODIFIED state.

In response to this:

Bug 2295778: osd: allow the AllowOsdCrushWeightUpdate flag always true

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants