forked from rook/rook
-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
external: enable the v2 port by default in downstream #748
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: parth-gr The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Testing: Even if the v2 flag is not passed
|
parth-gr
force-pushed
the
external-v2-down
branch
from
October 8, 2024 12:34
05499c0
to
8fbe820
Compare
/assign @travisn |
parth-gr
force-pushed
the
external-v2-down
branch
from
October 9, 2024 15:16
8fbe820
to
201b357
Compare
for 4.18 we will use the default v2 settings from the cluster CR So ask python script to fetch only v2 port Signed-off-by: parth-gr <[email protected]>
parth-gr
force-pushed
the
external-v2-down
branch
from
October 9, 2024 15:59
201b357
to
94be12b
Compare
LGTM after the CI passes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
for 4.18 we will use the default v2 settings from the cluster CR So ask python script to fetch only v2 port
Checklist: