Syncing latest changes from upstream master for rook #771
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
currently if we disable the monitoring for cephblockpool it didnt worked, as there was no check to cancel it if the mirroring is still enabled Add a check to disable the monitoring if mirroring is still enabled closes: rook#14958 Signed-off-by: parth-gr <[email protected]>
enable and disable the status of rados namespace mirroring by looking at statusCheck spec of blockpool Signed-off-by: parth-gr <[email protected]>
rbdmirror: fix mirroring monitoring settings for blockpool
Adding pool ID of the cephBlockPool in the CR status Signed-off-by: Santosh Pillai <[email protected]>
Previously arbiter monitors were allowed to failover in supported versions of Ceph. This behaviour regressed. Since all supported versions of Ceph now support this, we no longer need to check this at all. Signed-off-by: Grant Fleming <[email protected]>
…r-in-stretch operator: monitors should always be allowed to failover
core: add pool IDs to cephBlockPool CR status
df-build-team
force-pushed
the
sync_us--master
branch
from
7d0ade9
to
2290a16
Compare
openshift cluster need to have access to finalizers when we set the blockOwnerDeletion if an ownerReference refers to a resource we can't set finalizers on, This adds the extra required permission Signed-off-by: Madhu Rajanna <[email protected]>
df-build-team
force-pushed
the
sync_us--master
branch
from
2290a16
to
d6339dc
Compare
csi: add required finalizers for openshift
…-master Signed-off-by: Ceph Jenkins <[email protected]>
add generated csv changes Signed-off-by: Ceph Jenkins <[email protected]>
df-build-team
force-pushed
the
sync_us--master
branch
from
d6339dc
to
d785b22
Compare
subhamkrai
approved these changes
Nov 11, 2024
subhamkrai
added
the
approved
|
[APPROVALNOTIFIER] This PR is APPROVED Approval requirements bypassed by manually added approval. This pull-request has been approved by: df-build-team, subhamkrai The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR containing the latest commits from upstream master branch