[Faults] Require a strict method match when m is provided.
#701
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Do not allow matching when the configuration is for a specific method and the real method is unknown. The main idea here is that if someone wanted to inject a fault on the `foobar` method, a request with an unknown method should not also have that fault injected just because the primary address matched. Note that this has already been merged into bpv2 and this PR is just to get bpv0 on the same page.
HiramSilvey
requested review from
fishy,
konradreiche and
mathyourlife-reddit
and removed request for
a team
fishy
approved these changes
Jul 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do not allow matching when the configuration is for a specific method and the real method is unknown.
The main idea here is that if someone wanted to inject a fault on the
foobarmethod, a request with an unknown method should not also have that fault injected just because the primary address matched.Note that this has already been merged into bpv2 and this PR is just to get bpv0 on the same page. This will be followed by another PR getting bpv0 up to sync as well.