-
Notifications
You must be signed in to change notification settings - Fork 294
feat(KFLUXUI-504): Add banner content yaml and its kustomization files #6630
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(KFLUXUI-504): Add banner content yaml and its kustomization files #6630
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please move the content of https://github.com/testcara/konflux-banner into a directory in this repo (under the components directory)
Please deploy those configmap to the konflux-info
namespace since its purpose is to store information which is accessible by all authenticated users.
Thanks !
I really liked the implementation because it will also be possible to generate those confimaps with the banner details dynamically based on alerts. I left a comment above about the way it should be deployed. Thank you for working on this. |
I have a question, does each banner stored in its own configmap? I would like to also generate banners dynamically, it means that we would need the UI to read multiple configmaps with the banner details from the cluster. cc @sahil143 |
@gbenhaim Thank you for the review and quick response.
|
@gbenhaim could you help to double-confirm whether i got your suggestion correctly?
Thank you for the great help. :-) |
You can use the existing konflux-info argo app and component folder, no need to create a new one.
The rest is correct. I would also want to get a change in the ui so it would know how to read multiple configmaps from the cluster. Dynically generated configmap would be creates using automation directly in the cluster and not using prs. |
aa3b9de
to
46133f0
Compare
@gbenhaim hi, Gal, i refreshed the PR, could you help to review again? BTW, the description includes what the PR does or not covered, hope it makes the review a bit easier. Thank you for the help. |
46133f0
to
f63dc77
Compare
… github workflow files
f63dc77
to
30c6b01
Compare
d093746
to
930461d
Compare
@gbenhaim i tried to support the two kinds of banners now, see the https://drive.google.com/file/d/17X3qkgLD7aXWq_wnuteAWUu3WE7_J2M5/view. looking forward to any feedback. thank you. |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: gbenhaim, testcara The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
kind: ConfigMap | ||
metadata: | ||
labels: | ||
konflux-auto-alert: "true" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i would change the label to recommended way like 'app.kubernetes.io/name: my-app'
6a72b29
into
redhat-appstudio:main
KFLUXUI-500 aims to provide konflux banner to users.
The PR does:
supporting the single manual banner:
supporting the multiple auto generated alerts:
Here is one video about how UI integrate with them:
https://drive.google.com/file/d/17X3qkgLD7aXWq_wnuteAWUu3WE7_J2M5/view