Skip to content

Update cost-management Kyverno policies in prod #6649

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Update cost-management Kyverno policies in prod #6649

wants to merge 2 commits into from
+624 −1

Conversation

raks-tt
Copy link
Contributor

@raks-tt raks-tt commented Jun 10, 2025 •
edited
Loading

Apply cost-management Kyverno policies to selected prod clusters

  • Do not apply to rh01
  • Do not apply to host1 as it will be decommissioned

@openshift-ci openshift-ci bot requested review from lcarva and tisutisu June 10, 2025 16:55
@raks-tt raks-tt force-pushed the prod_policywq branch 2 times, most recently from d7a22e5 to bdeba78 Compare June 10, 2025 17:00
@raks-tt raks-tt mentioned this pull request Jun 10, 2025
Merged
@raks-tt raks-tt force-pushed the prod_policywq branch 2 times, most recently from c705abf to 9a02ff2 Compare June 10, 2025 17:36
@mftb
Copy link
Contributor

mftb commented Jun 10, 2025

/ok-to-test

mftb
mftb approved these changes Jun 10, 2025
View reviewed changes
Copy link
Contributor

@mftb mftb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm label Jun 10, 2025
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Jun 10, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: mftb, raks-tt
Once this PR has been reviewed and has the lgtm label, please assign johnmcollier for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

filariow
filariow reviewed Jun 10, 2025
View reviewed changes
@openshift-ci openshift-ci bot removed the lgtm label Jun 10, 2025
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Jun 10, 2025

New changes are detected. LGTM label has been removed.

Apply cost-management Kyverno policies to selected prod clusters
6d92b90 
- Do not apply to rh01
- Do not apply to host1 as it will be decommissioned

Signed-off-by: rrajashe <[email protected]>
@filariow
Copy link
Member

@raks-tt did we test in staging if the webhook is not blocking pod creation when kyverno is disconnected?

@raks-tt
Copy link
Contributor Author

raks-tt commented Jun 11, 2025

@raks-tt did we test in staging if the webhook is not blocking pod creation when kyverno is disconnected?

I tested it locally with a test case and it worked fine.

@openshift-merge-robot
Copy link
Collaborator

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hugares hugares hugares left review comments

@filariow filariow filariow left review comments

@mftb mftb mftb approved these changes

@lcarva lcarva Awaiting requested review from lcarva

@tisutisu tisutisu Awaiting requested review from tisutisu

Assignees

@mftb mftb

Labels
do-not-merge/hold needs-rebase ok-to-test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@raks-tt @mftb @filariow @openshift-merge-robot @hugares