Skip to content

fix(STONEINTG-1259): disable integration leader election #6786

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 8, 2025
Merged

fix(STONEINTG-1259): disable integration leader election #6786

merged 1 commit into from
Jul 8, 2025

Conversation

dirgim
Copy link
Member

@dirgim dirgim commented Jun 18, 2025 •
edited
Loading

  • Disable the leader election for the integration service controller manager in staging/development
  • The leader election is not needed for the integration service at this point
  • The etcd defragmentation is causing pods to restart when failing to renew the lease

Signed-off-by: dirgim [email protected]

@openshift-ci openshift-ci bot requested review from jencull and kasemAlem June 18, 2025 08:39
sonam1412
sonam1412 approved these changes Jun 18, 2025
View reviewed changes
Copy link
Contributor

@sonam1412 sonam1412 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

hongweiliu17
hongweiliu17 approved these changes Jun 18, 2025
View reviewed changes
Copy link
Member

@hongweiliu17 hongweiliu17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@dirgim dirgim added the lgtm label Jun 18, 2025
jsztuka
jsztuka approved these changes Jun 18, 2025
View reviewed changes
Copy link
Member

@jsztuka jsztuka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@dirgim
Copy link
Member Author

dirgim commented Jun 18, 2025

/test appstudio-e2e-tests

2 similar comments
@dirgim
Copy link
Member Author

dirgim commented Jun 18, 2025

/test appstudio-e2e-tests

@dirgim
Copy link
Member Author

dirgim commented Jun 18, 2025

/test appstudio-e2e-tests

@dirgim
Copy link
Member Author

dirgim commented Jun 18, 2025

/retest

1 similar comment
@hongweiliu17
Copy link
Member

/retest

@hongweiliu17
Copy link
Member

/test appstudio-e2e-tests

3 similar comments
@dirgim
Copy link
Member Author

dirgim commented Jun 19, 2025

/test appstudio-e2e-tests

@dirgim
Copy link
Member Author

dirgim commented Jun 19, 2025

/test appstudio-e2e-tests

@dirgim
Copy link
Member Author

dirgim commented Jun 19, 2025

/test appstudio-e2e-tests

@dirgim
Copy link
Member Author

dirgim commented Jun 19, 2025

/retest-required

@hongweiliu17
Copy link
Member

/test appstudio-e2e-tests

8 similar comments
@dirgim
Copy link
Member Author

dirgim commented Jun 20, 2025

/test appstudio-e2e-tests

@kasemAlem
Copy link
Member

/test appstudio-e2e-tests

@hongweiliu17
Copy link
Member

/test appstudio-e2e-tests

@dirgim
Copy link
Member Author

dirgim commented Jun 24, 2025

/test appstudio-e2e-tests

@dirgim
Copy link
Member Author

dirgim commented Jun 25, 2025

/test appstudio-e2e-tests

@dirgim
Copy link
Member Author

dirgim commented Jun 25, 2025

/test appstudio-e2e-tests

@dirgim
Copy link
Member Author

dirgim commented Jun 25, 2025

/test appstudio-e2e-tests

@dirgim
Copy link
Member Author

dirgim commented Jun 25, 2025

/test appstudio-e2e-tests

@openshift-ci openshift-ci bot added the lgtm label Jun 26, 2025
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Jun 26, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dirgim, filariow, hongweiliu17, jsztuka, kasemAlem, sonam1412

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kasemAlem
Copy link
Member

/test appstudio-e2e-tests

@kasemAlem
Copy link
Member

/test appstudio-upgrade-tests

@hongweiliu17
Copy link
Member

/test appstudio-e2e-tests

2 similar comments
@dirgim
Copy link
Member Author

dirgim commented Jun 27, 2025

/test appstudio-e2e-tests

@dirgim
Copy link
Member Author

dirgim commented Jun 27, 2025

/test appstudio-e2e-tests

@openshift-ci openshift-ci bot removed the lgtm label Jun 27, 2025
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Jun 27, 2025

New changes are detected. LGTM label has been removed.

@dirgim dirgim added the lgtm label Jun 27, 2025
@dirgim
Copy link
Member Author

dirgim commented Jun 27, 2025

/retest

@openshift-ci openshift-ci bot removed the lgtm label Jun 27, 2025
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Jun 27, 2025

New changes are detected. LGTM label has been removed.

@dirgim dirgim added the lgtm label Jun 27, 2025
@dirgim
Copy link
Member Author

dirgim commented Jun 27, 2025

/retest-required

@dirgim
Copy link
Member Author

dirgim commented Jun 29, 2025

/retest

@hongweiliu17
Copy link
Member

/test appstudio-e2e-tests

3 similar comments
@dirgim
Copy link
Member Author

dirgim commented Jun 30, 2025

/test appstudio-e2e-tests

@kasemAlem
Copy link
Member

/test appstudio-e2e-tests

@dirgim
Copy link
Member Author

dirgim commented Jun 30, 2025

/test appstudio-e2e-tests

@dirgim
fix(STONEINTG-1259): disable integration leader election
fdfea79 
* Disable the leader election for the integration service
  controller manager in staging and development envs

Signed-off-by: dirgim <[email protected]>

rh-pre-commit.version: 2.2.0
rh-pre-commit.check-secrets: ENABLED
@openshift-ci openshift-ci bot removed the lgtm label Jul 1, 2025
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Jul 1, 2025

New changes are detected. LGTM label has been removed.

@dirgim dirgim added the lgtm label Jul 1, 2025
@kasemAlem
Copy link
Member

/retest

@kasemAlem
Copy link
Member

/test appstudio-e2e-tests

@openshift-merge-bot openshift-merge-bot bot merged commit 30ff6ee into redhat-appstudio:main Jul 8, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hongweiliu17 hongweiliu17 hongweiliu17 approved these changes

@kasemAlem kasemAlem kasemAlem approved these changes

@sonam1412 sonam1412 sonam1412 approved these changes

@jsztuka jsztuka jsztuka approved these changes

@jencull jencull Awaiting requested review from jencull

Assignees

@filariow filariow

Labels
approved lgtm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@dirgim @hongweiliu17 @kasemAlem @filariow @sonam1412 @jsztuka