-
Notifications
You must be signed in to change notification settings - Fork 294
Make appstudio-pipelines-runner role common for all overlays #6947
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make appstudio-pipelines-runner role common for all overlays #6947
Conversation
Signed-off-by: Max Shaposhnyk <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
great work, some suggestions on the procedure
components/sandbox/toolchain-member-operator/base/rbac/kustomization.yaml
Outdated
Show resolved
Hide resolved
d5e06fb
to
0e8cb90
Compare
Co-authored-by: Francesco Ilario <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: filariow, mshaposhnik The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
f3ec620
into
redhat-appstudio:main
…appstudio#6947) * Make appstudio-pipelines-runner role common for all overlays Signed-off-by: Max Shaposhnyk <[email protected]> * fixup! Make appstudio-pipelines-runner role common for all overlays * Do not update production so far Co-authored-by: Francesco Ilario <[email protected]> --------- Signed-off-by: Max Shaposhnyk <[email protected]> Co-authored-by: Francesco Ilario <[email protected]>
it is moved outside of sandbox