Skip to content

Make appstudio-pipelines-runner role common for all overlays #6947

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

mshaposhnik
Copy link
Contributor

it is moved outside of sandbox

@openshift-ci openshift-ci bot requested review from gbenhaim and sadlerap July 1, 2025 11:17
@mshaposhnik mshaposhnik requested review from filariow and removed request for gbenhaim July 2, 2025 06:35
Copy link
Member

@filariow filariow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great work, some suggestions on the procedure

Co-authored-by: Francesco Ilario <[email protected]>
Copy link
Member

@filariow filariow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

Copy link

openshift-ci bot commented Jul 2, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: filariow, mshaposhnik

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label Jul 2, 2025
@openshift-merge-bot openshift-merge-bot bot merged commit f3ec620 into redhat-appstudio:main Jul 2, 2025
7 checks passed
gcpsoares pushed a commit to gcpsoares/infra-deployments that referenced this pull request Jul 2, 2025
…appstudio#6947)

* Make appstudio-pipelines-runner role common for all overlays

Signed-off-by: Max Shaposhnyk <[email protected]>

* fixup! Make appstudio-pipelines-runner role common for all overlays

* Do not update production so far

Co-authored-by: Francesco Ilario <[email protected]>

---------

Signed-off-by: Max Shaposhnyk <[email protected]>
Co-authored-by: Francesco Ilario <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants