-
Notifications
You must be signed in to change notification settings - Fork 33
Remove pre-defined role for service accounts #856
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Remove pre-defined role for service accounts #856
Conversation
Skipping CI for Draft Pull Request. |
8c5321b
to
7e4a357
Compare
7e4a357
to
e709faf
Compare
e709faf
to
392b3a3
Compare
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lingyzhuang, Roming22 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@lingyzhuang: The following test has Failed, say /retest to rerun failed tests.
Inspecting Test ArtifactsTo inspect your test artifacts, follow these steps:
mkdir -p oras-artifacts
cd oras-artifacts
oras pull quay.io/konflux-test-storage/rhtap-team/rhtap-cli:e2e-4.17-jm4z5 Test results analysis<not enabled> |
In
_common/_service-account.tpl
file:ServiceAccount
ClusterRole
with permissions read/create/delete/patch to secrets. Bind this role to namespaces.Release.Namespace
andtssc
RoleBinding
binds a role to a specific namespace (.Release.Namespace
)Remove
Cluster-admin
ClusterRole, use read-only ClusterRole and secret read-write ClusterRole instead.ServiceAccount in chart
tssc-gitops
needs all verbs to all the resources to do some configurations, so create aRole
and bind it to namespace tssc-gitops.Jira: RHTAP-4880