Add message fixture to conftest#116
Open
MaayanMashhadi wants to merge 1 commit intoredhat-beyond:mainfrom
Open
Add message fixture to conftest#116MaayanMashhadi wants to merge 1 commit intoredhat-beyond:mainfrom
MaayanMashhadi wants to merge 1 commit intoredhat-beyond:mainfrom
Conversation
also, changing the test message file
Collaborator
|
Do you use the message fixture somewhere else beside the message tests? @MaayanMashhadi |
Collaborator
Author
I don't think so. As I see, the message fixture is only used in the message tests. |
|
I think we don't need to move something that is not used by any other test in the project |
Collaborator
|
I think its good convention to do it like that. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Desired Outcome
one fixture of message in conftest and rename the message fixture from saved_message to message,
will make the code more readable.
Implemented Changes
Connected Issue/Story
Resolves #115
Resolves #106
Dependencies
Test coverage
Documentation