remove controller_api_plugin and eda_api_plugin variables in favour of ansible.platform.gateway_api

[ivarmu]

What does this PR do?

The collection to be used for AAP >= 2.5 is ansible.platform, so the API plugin to be used for all the endpoints is ansible.platform.gateway_api.

How should this be tested?

Manually tested

Is there a relevant Issue open for this?

N/A

Other Relevant info, PRs, etc

N/A

[adonisgarciac]

Wouldn’t this break setups that rely on the upstream awx.awx collection?

[ivarmu]

Wouldn’t this break setups that rely on the upstream awx.awx collection?

I think awx.awx collection is not supporting the AAP 2.5 API endpoints...

[adonisgarciac]

I think it does if we specify the path of the API endpoint like api/controller/v2/ or api/gateway/v1/

[ivarmu]

Please, take a look at the conversation at redhat-cop/infra.aap_configuration#1092

[Tompage1994]

LGTM, but can you add a changelog fragment please.

[ivarmu]

I'm not sure how to fix the CI... @Tompage1994 @djdanielsson @sean-m-sullivan any ideas?

[silvinux]

I'm not sure how to fix the CI... @Tompage1994 @djdanielsson @sean-m-sullivan any ideas?

Hi @Tompage1994 @djdanielsson @sean-m-sullivan,

It seems that the issue might be related to the collections required from console.redhat.com not being downloaded properly. @ivarmu already added [1], which points to the pre_commit_workflow_crc workflow in the ansible_collections_tooling repository.

As seen in [2] and [3], it looks like the environment variable ANSIBLE_GALAXY_SERVER_*_TOKEN [4] is empty — specifically, the ansible_ah_token [5] variable appears to be unset.

Could you kindly check whether the secret CRC_PUBLISH_KEY has been created correctly in the repository settings?

Thanks in advance for your help!

[1].-https://github.com/redhat-cop/aap_configuration_extended/pull/116/files#diff-ac5eead3f3ce4863c524fff031a87b7aecccb4a0493df087a4e1c704a1505036
[2].-https://github.com/redhat-cop/aap_configuration_extended/actions/runs/15821266435/job/44590879439#step:5:12
[3].-ttps://github.com/redhat-cop/infra.aap_configuration/actions/runs/15816750092/job/44576910533#step:5:12
[4].-https://github.com/redhat-cop/infra.aap_configuration/blob/devel/.github/workflows/pre-commit.yml#L31C23-L31C24
[5].-https://github.com/redhat-cop/ansible_collections_tooling/blob/main/.github/workflows/pre-commit_crc.yml#L46C62-L46C78

[Tompage1994]

Looks like the problem is an incorrect api token for console.redhat.com. I'll replace it and try rerunning

[Tompage1994]

Ok, I'm pretty certain that the CI is failing because it doesn't pick up the changes under .github. I've seen this behaviour before (although what the actions tells you is hard to understand what it's actually doing)

It looks good to me, so I'm going to approve it and if the CI still fails we will work from there