Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enable multi-az in rosa classic sts #9031

Open
wants to merge 2 commits into
base: development
Choose a base branch
from

Conversation

newgoliath
Copy link
Collaborator

  • Bugfix Pull Request

I somehow missed getting this committed before RH1.

Might alleviate lack of baremetal machines

@newgoliath newgoliath requested a review from a team as a code owner February 6, 2025 22:05
@newgoliath newgoliath marked this pull request as draft February 6, 2025 22:06
@newgoliath newgoliath requested a review from wkulhanek February 6, 2025 22:06
- name: Create list of AZs
when: rosa_classic_multi_az | bool
ansible.builtin.set_fact:
_rosa_sts_azs: |
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about us-east-1 which has a-f?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ends up I don't need any of them. --multi-az should figure it out itself.

When creating machinepools in a multi-az rosa, machines should be automatically spread between AZ.

🤞

@newgoliath newgoliath force-pushed the judd-rosa-consolidated-sts-multiaz branch from 29e0456 to eac5c13 Compare February 6, 2025 22:17
fix command

variable name
@newgoliath newgoliath force-pushed the judd-rosa-consolidated-sts-multiaz branch from eac5c13 to 09cb380 Compare February 6, 2025 22:19
@newgoliath
Copy link
Collaborator Author

Works OK as long as machinepool_replicas is a mulitple of 3

@newgoliath newgoliath marked this pull request as ready for review February 7, 2025 04:01
@newgoliath newgoliath requested a review from wkulhanek February 7, 2025 04:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants