Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the example #53

Merged
merged 1 commit into from
Mar 12, 2024
Merged

Update the example #53

merged 1 commit into from
Mar 12, 2024

Conversation

p3ck
Copy link
Contributor

@p3ck p3ck commented Mar 5, 2024

The current example doesn't work since it's missing the name of the postgresql server and the disk size is invalid according to azure.

Copy link
Contributor

@alinabuzachis alinabuzachis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@p3ck Can you please add a trivial changelog fragment for this change https://docs.ansible.com/ansible/latest/community/development_process.html#creating-a-changelog-fragment? Thanks.

@p3ck p3ck force-pushed the postgresql_example branch from e0b7035 to 8a8fabf Compare March 5, 2024 13:49
Copy link
Contributor

@alinabuzachis alinabuzachis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@p3ck Thank you. CI issues are not related to this change. This LGTM!

@alinabuzachis
Copy link
Contributor

@p3ck Can you please rebase? Thanks.

The current example doesn't work since it's missing the name of the
postgresql server and the disk size is invalid according to azure.
@p3ck p3ck force-pushed the postgresql_example branch from 8a8fabf to 6234436 Compare March 11, 2024 14:55
@alinabuzachis alinabuzachis requested a review from abikouo March 12, 2024 09:17
@abikouo abikouo merged commit 16ea8a8 into redhat-cop:main Mar 12, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants