add(): add CRD for GCPAuthEngineConfig#242
Conversation
|
@erlisb could you resolve the conflicts? |
|
Done |
|
there is something wrong here, the |
raffaelespazzoli
left a comment
raffaelespazzoli
left a comment
There was a problem hiding this comment.
where is the actual code for this engine config?
config/webhook/manifests.yaml
Outdated
| name: webhook-service | ||
| namespace: system | ||
| path: /mutate-redhatcop-redhat-io-v1alpha1-databasesecretengineconfig | ||
| path: /mutate-redhatcop-redhat-io-v1alpha1-gcpauthengineconfig |
There was a problem hiding this comment.
is this correct, it seems you are replacing the databasesecretengineconfig, this file is automatically generated, just run make manifests
| - get | ||
| - patch | ||
| - update | ||
| - apiGroups: |
There was a problem hiding this comment.
there is a problem here, again please generate this file with make config.
| path: /mutate-redhatcop-redhat-io-v1alpha1-databasesecretengineconfig | ||
| path: /mutate-redhatcop-redhat-io-v1alpha1-gcpauthengineconfig | ||
| failurePolicy: Fail | ||
| name: mdatabasesecretengineconfig.kb.io |
There was a problem hiding this comment.
also these substitutions look suspicious, please regenerate this file with make manifests
|
@raffaelespazzoli I regenerated the affected manifests. Please, check again. Thanks. |
|
Hi @raffaelespazzoli kind reminder! |
|
@erlisb can you re-base and fix the conflicts |
2 participants
This PR consists in :
API Resource / CRD for GCPAuthEngineConfig
Defaulter / Validator Webhook for GCPAuthEngineConfig CRD
Controller Reconciliator for for GCPAuthEngineConfig CRD
Documentation for GCPAuthEngineConfig CRD
@raffaelespazzoli , please review it.
Thnx