Skip to content

feat: Add support for pnpm package manager #180

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 21, 2025
Merged

feat: Add support for pnpm package manager #180

merged 2 commits into from
May 21, 2025

Conversation

soul2zimate
Copy link
Collaborator

@soul2zimate soul2zimate commented May 20, 2025 •
edited
Loading

feat: Add support for pnpm package manager

Fixes: #176

This requires trustification/exhort-java-api#133

@soul2zimate soul2zimate changed the title Issue176 main Add support for pnpm package manager May 20, 2025
@ruromero ruromero self-requested a review May 21, 2025 06:40
ruromero
ruromero requested changes May 21, 2025
View reviewed changes
Copy link
Collaborator

@ruromero ruromero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I could only find the typo during the review. I don't think there's anything else that requires fixing.
Can you also review the CI checks and make sure they're passing?
Thanks

@soul2zimate
Copy link
Collaborator Author

The CI is complaining about The job was not started because recent account payments have failed or your spending limit needs to be increased. Please check the 'Billing & plans' section in your settings 😢

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@soul2zimate soul2zimate changed the title Add support for pnpm package manager feat: Add support for pnpm package manager May 21, 2025
@soul2zimate
Copy link
Collaborator Author

The CI is all good now.

@soul2zimate soul2zimate requested a review from ruromero May 21, 2025 07:24
@soul2zimate soul2zimate merged commit f45d3b0 into redhat-developer:main May 21, 2025
10 of 11 checks passed
@soul2zimate soul2zimate deleted the issue176-main branch May 21, 2025 07:36
@soul2zimate soul2zimate added this to the 202507 milestone Jun 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ruromero ruromero ruromero approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
202507
Development

Successfully merging this pull request may close these issues.

Add support for pnpm package manager
2 participants
@soul2zimate @ruromero