feat: add gh actions runner setup for mac on aws #264
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Did you test this one? I mean did you create a mac machine? |
yes its tested now :) |
adrianriobo
reviewed
Jul 22, 2024
pkg/util/ghactions/runner.go
Outdated
| @@ -75,3 +86,10 @@ func GetActionRunnerSnippetLinux() string { | |||
| } | |||
| return util.IfNillable(args != nil, snippetLinux, "") | |||
| } | |||
|
|
|||
| func GetActionRunnerSnippetMacos() string { | |||
| return util.If(args != nil, | |||
There was a problem hiding this comment.
You should use same syntax as others with util.IfNillable otherwise f not ghtunner params passed it will panic (I think)
There was a problem hiding this comment.
ahh, yes
updated now, thanks!
this adds new flags to the command `mapt aws mac request` to to install github actions runner on the provisioned instance it also adds the additional flags to get the various values needed to setup the github actions runner Signed-off-by: Anjan Nath <[email protected]>
Signed-off-by: Anjan Nath <[email protected]>
|
Fixes #197 |
adrianriobo
approved these changes
Jul 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this adds new flags to the command
mapt aws mac requestto to install github actions runner on the provisioned instanceit also adds the additional flags to get the various values needed to setup the github actions runner