feat: added support for spot instances with GPU enabled #408
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adrianriobo
force-pushed
the
fix-406
branch
3 times, most recently
from
e990468 to
b2dd33b
Compare
adrianriobo
force-pushed
the
fix-406
branch
4 times, most recently
from
7939c7f to
013891c
Compare
adrianriobo
force-pushed
the
fix-406
branch
3 times, most recently
from
2dcedc1 to
ae43485
Compare
Signed-off-by: Adrian Riobo <[email protected]>
previously the code for both providers where outside of the proivders folder, also type of machines were described only baed in params, now there are some interfaces defined as api pkg, and it is expectred each provider implement those apis, also implementations has been moved to each provider so keep code clean and it supports now set specific types in which case it would take precedence over params for the type of machines Signed-off-by: Adrian Riobo <[email protected]>
Signed-off-by: Adrian Riobo <[email protected]>
adrianriobo
changed the title
Previously when something went wrong when requesting the VM the readiness command had not explicit dependecy on it, and it has a 40 mins timeout, then if machines is not created readiness fails...but keep running for 40 mins until mapt ends up on error. This commit exposes resources from Compute as Dependecies (on AWS) then we can link any remote command as explicit to the Compute resources, and if those are not created mapt exists on error right away Signed-off-by: Adrian Riobo <[email protected]>
Signed-off-by: Adrian Riobo <[email protected]>
anjannath
approved these changes
Jul 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #406