Skip to content

openshift-snc: change command checking if kubeconfig is updated #516

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 20, 2025

Conversation

anjannath
Copy link
Collaborator

the ocp-cluster-ca.service after changing the cluster CA writes a new kubeconfig file with updated client certificates for the system:admin user and the token for kubeadmin user, this changes the command that checked for the status of the ocp-cluster-ca.service to instead check if the kubeconfig file at /opt/crc/kubeconfig is created

fixes #510

Copy link
Collaborator

@adrianriobo adrianriobo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

the ocp-cluster-ca.service after changing the cluster CA writes a new
kubeconfig file with updated client certificates for the system:admin
user and the token for kubeadmin user, this changes the command  that
checked for the status of the ocp-cluster-ca.service to instead check
if the kubeconfig file at /opt/crc/kubeconfig is created
Copy link
Collaborator

@adrianriobo adrianriobo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM once tested merge, up to you

@anjannath anjannath merged commit 8087467 into redhat-developer:main Jun 20, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[openshift-snc] kubeconfig file is copied out too early
2 participants