Skip to content

Add knative crds + move knative CRs to plugin-infra #1219

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

jenniferubah
Copy link

@jenniferubah jenniferubah commented Jun 3, 2025

Description

Currently, the Knative CRs (managed by Serverless Operator) are created as part of the plugin-deps. However, this should be part of the plugin-infra because there will be risks of failure when changes are made to the these CRs (by the admin) and the RHDH operator attempts reapplication/reconciliation/reversion since the plugin-deps are handled by the operator.

Which issue(s) does this PR fix or relate to

  • Relates to Enable plugins dependencies for merging Orchestrator into RHDH.

PR acceptance criteria

  • Knative CRs should be applied during the plugin infrastructure set up instead of afterwards.

  • Tests

  • Documentation

How to test changes / Special notes to the reviewer

Pull the changes, run make plugin-infra deploy IMG={IMG}
This should apply the knative CRs and create the resources after the serverless operator is ready.

Copy link

openshift-ci bot commented Jun 3, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign rm3l for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Contributor

github-actions bot commented Jun 3, 2025

⚠️ Files changed in bundle and installer generation!

Those changes to the operator bundle/installer manifests should have been pushed automatically to your PR branch.

NOTE: If the PR checks are stuck after this additional commit, manually close the PR and immediately reopen it to trigger the checks again.

@jenniferubah
Copy link
Author

@gazarenkov @masayag PTAL

@masayag
Copy link

masayag commented Jun 5, 2025

LGTM.
Did you try installing the openshift-serverless operator from the console after installing RHDH?
Just to make sure there isn't any conflict between importing CRDs for knative by RHDH to the one installed by the openshift-serverless operator.

@jenniferubah
Copy link
Author

jenniferubah commented Jun 9, 2025

LGTM. Did you try installing the openshift-serverless operator from the console after installing RHDH? Just to make sure there isn't any conflict between importing CRDs for knative by RHDH to the one installed by the openshift-serverless operator.

Thanks! No, I didn't test that. I will test it out and provide feedback. Good point.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants