feat(scorecard): add support for the New Frontend System (NFS)#2487
Open
rohitratannagar wants to merge 6 commits intoredhat-developer:mainfrom
Open
feat(scorecard): add support for the New Frontend System (NFS)#2487rohitratannagar wants to merge 6 commits intoredhat-developer:mainfrom
rohitratannagar wants to merge 6 commits intoredhat-developer:mainfrom
Conversation
Signed-off-by: rohitratannagar <[email protected]>
rohitratannagar
requested review from
a team,
Eswaraiahsapram,
christoph-jerolimov and
its-mitesh-kumar
as code owners
Review Summary by QodoAdd New Frontend System (NFS) support to scorecard plugin
WalkthroughsDescription• Add New Frontend System (NFS) support to scorecard plugin • Create app-next package with NFS-based Backstage application • Implement scorecard catalog module with configurable entity kinds • Add scorecard translations module for internationalization support Diagramflowchart LR
A["scorecard plugin"] -->|"exports alpha API"| B["alpha.tsx"]
B -->|"provides"| C["scorecardApi"]
B -->|"provides"| D["createScorecardCatalogModule"]
B -->|"provides"| E["scorecardTranslationsModule"]
F["app-next package"] -->|"imports"| B
F -->|"creates app with"| C
F -->|"creates app with"| D
F -->|"creates app with"| E
File Changes1. workspaces/scorecard/packages/app-next/public/index.html
|
Missing ChangesetsThe following package(s) are changed by this PR but do not have a changeset:
See CONTRIBUTING.md for more information about how to add changesets. Changed Packages
|
Code Review by Qodo
1.
|
Signed-off-by: rohitratannagar <[email protected]>
![rhdh-qodo-merge[bot]](https://avatars.githubusercontent.com/in/1961108?s=60&v=4){kind=small}
Comment on lines
+74
to
+82
| const filter = | ||
| options?.entityKinds?.length && | ||
| `kind:${options.entityKinds.map(k => k.toLowerCase()).join(',')}`; | ||
| return EntityContentBlueprint.make({ | ||
| name: 'scorecard', | ||
| params: { | ||
| ...defaultScorecardEntityContentParams, | ||
| ...(filter && { filter }), | ||
| }, |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
Signed-off-by: rohitratannagar <[email protected]>
4 tasks
Signed-off-by: rohitratannagar <[email protected]>
Signed-off-by: rohitratannagar <[email protected]>
Contributor
Author
|
/cc @rohitkrai03 |
Signed-off-by: rohitratannagar <[email protected]>
rohitratannagar
force-pushed
the
feat/scorecard-nfs-migration
branch
from
66d63f5 to
22e3a7c
Compare
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey, I just made a Pull Request!
Description
Fixes
scorecard entity tab -- when options are passed
Screen.Recording.2026-03-06.at.3.34.08.PM.mov
scorecard entity tab -- when options are not passed (Scorecard is shown for each kind of entity)
Screen.Recording.2026-03-06.at.3.38.40.PM.mov
Legacy App after changes
Screen.Recording.2026-03-06.at.4.00.03.PM.mov
✔️ Checklist