-
Notifications
You must be signed in to change notification settings - Fork 197
fix(metrics): make metrics working for RHDH executed via cli #2817
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
fix(metrics): make metrics working for RHDH executed via cli #2817
Conversation
@AndrienkoAleksandr: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
This PR is stale because it has been open 7 days with no activity. Remove stale label or comment or this will be closed in 21 days. |
8a9e6c9
to
319ea59
Compare
Signed-off-by: Oleksandr Andriienko <[email protected]>
319ea59
to
7cd3b15
Compare
The image is available at: |
This PR is stale because it has been open 7 days with no activity. Remove stale label or comment or this will be closed in 21 days. |
This PR is stale because it has been open 7 days with no activity. Remove stale label or comment or this will be closed in 21 days. |
This PR is stale because it has been open 7 days with no activity. Remove stale label or comment or this will be closed in 21 days. |
This PR is stale because it has been open 7 days with no activity. Remove stale label or comment or this will be closed in 21 days. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Description
Make metrics working for RHDH executed via cli. Basically we need it for
yarn dev
command to fix http://localhost:9464/metrics endpoint. For the production container, we don't need this fix because RHDH is executed there using a Node process without the CLI.Docs
https://github.com/backstage/backstage/blob/13983915965564d71ede93fb1705f0abd79df41a/docs/tutorials/setup-opentelemetry.md#configure
Which issue(s) does this PR fix
PR acceptance criteria
Please make sure that the following steps are complete:
How to test changes / Special notes to the reviewer