Skip to content

fix(metrics): make metrics working for RHDH executed via cli #2817

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

AndrienkoAleksandr
Copy link
Contributor

@AndrienkoAleksandr AndrienkoAleksandr commented Apr 28, 2025

Description

Make metrics working for RHDH executed via cli. Basically we need it for yarn dev command to fix http://localhost:9464/metrics endpoint. For the production container, we don't need this fix because RHDH is executed there using a Node process without the CLI.

Docs

https://github.com/backstage/backstage/blob/13983915965564d71ede93fb1705f0abd79df41a/docs/tutorials/setup-opentelemetry.md#configure

Which issue(s) does this PR fix

PR acceptance criteria

Please make sure that the following steps are complete:

  • GitHub Actions are completed and successful
  • Unit Tests are updated and passing
  • E2E Tests are updated and passing
  • Documentation is updated if necessary (requirement for new features)
  • Add a screenshot if the change is UX/UI related

How to test changes / Special notes to the reviewer

Copy link

openshift-ci bot commented Apr 28, 2025

@AndrienkoAleksandr: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-tests 8a9e6c97013ca1ed95015b88378f5d874dcd1af3 link true /test e2e-tests

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Copy link
Contributor

github-actions bot commented May 8, 2025

This PR is stale because it has been open 7 days with no activity. Remove stale label or comment or this will be closed in 21 days.

@github-actions github-actions bot added the Stale label May 8, 2025
@AndrienkoAleksandr AndrienkoAleksandr force-pushed the fix-metics-script-for-rhdh-executed-via-cli branch from 8a9e6c9 to 319ea59 Compare May 8, 2025 11:02
@AndrienkoAleksandr AndrienkoAleksandr force-pushed the fix-metics-script-for-rhdh-executed-via-cli branch from 319ea59 to 7cd3b15 Compare May 8, 2025 11:03
Copy link
Contributor

github-actions bot commented May 8, 2025

@github-actions github-actions bot removed the Stale label May 9, 2025
Copy link
Contributor

This PR is stale because it has been open 7 days with no activity. Remove stale label or comment or this will be closed in 21 days.

Copy link
Contributor

This PR is stale because it has been open 7 days with no activity. Remove stale label or comment or this will be closed in 21 days.

Copy link
Contributor

github-actions bot commented Jun 8, 2025

This PR is stale because it has been open 7 days with no activity. Remove stale label or comment or this will be closed in 21 days.

Copy link
Contributor

This PR is stale because it has been open 7 days with no activity. Remove stale label or comment or this will be closed in 21 days.

Copy link

openshift-ci bot commented Jul 24, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign kim-tsao for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@github-actions github-actions bot removed the Stale label Jul 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛 Bug Report: Open telemetry missed plugin metrics
1 participant