-
Notifications
You must be signed in to change notification settings - Fork 197
chore(deps): update bulk-import wrappers #3180
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
chore(deps): update bulk-import wrappers #3180
Conversation
The image is available at: |
/hold |
Signed-off-by: Dominika Zemanovicova <[email protected]>
Signed-off-by: Dominika Zemanovicova <[email protected]>
2512525
to
e889f7f
Compare
The image is available at: |
Tested on a cluster: bulk-import-create-pr.mov |
The image is available at: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/retest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dzemanov Perhaps you can consider re-enabling the bulk import test that was skipped in https://github.com/redhat-developer/rhdh/pull/3105/files#diff-022a62fbf830a6fe2740f9e75c5cc80c7ae4e45a9f52b119002d9eb23be42a9f, to confirm that the tests pass with this PR?
Or are you planning to do this in a subsequent PR?
@rm3l oh yeah, that needs to be reenabled, thank you for pointing it out. I will update this PR. |
Signed-off-by: Dominika Zemanovicova <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
The image is available at: |
/retest |
e2e tests are detecting another error with Edit PR: https://issues.redhat.com/browse/RHDHBUGS-1908, I will have a fix for that soon and will update the wrapper in this PR. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: AndrienkoAleksandr, PatAKnight, rm3l The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: Dominika Zemanovicova <[email protected]>
New changes are detected. LGTM label has been removed. |
The image is available at: |
/retest |
@dzemanov: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Description
Updates bulk-import wrappers.
Which issue(s) does this PR fix
PR acceptance criteria
Please make sure that the following steps are complete:
How to test changes / Special notes to the reviewer