Skip to content

chore(deps): update bulk-import wrappers #3180

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

dzemanov
Copy link
Member

Description

Updates bulk-import wrappers.

Which issue(s) does this PR fix

PR acceptance criteria

Please make sure that the following steps are complete:

  • GitHub Actions are completed and successful
  • Unit Tests are updated and passing
  • E2E Tests are updated and passing
  • Documentation is updated if necessary (requirement for new features)
  • Add a screenshot if the change is UX/UI related

How to test changes / Special notes to the reviewer

Copy link
Contributor

@dzemanov
Copy link
Member Author

/hold

dzemanov added 2 commits July 23, 2025 20:02
Signed-off-by: Dominika Zemanovicova <[email protected]>
Signed-off-by: Dominika Zemanovicova <[email protected]>
@dzemanov dzemanov force-pushed the update-bulk-import-wrapper branch from 2512525 to e889f7f Compare July 23, 2025 18:02
Copy link
Contributor

@dzemanov
Copy link
Member Author

Tested on a cluster:

bulk-import-create-pr.mov

@openshift-ci openshift-ci bot removed the lgtm label Jul 24, 2025
Copy link
Contributor

Copy link
Member

@PatAKnight PatAKnight left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@PatAKnight
Copy link
Member

/retest

Copy link
Member

@rm3l rm3l left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dzemanov Perhaps you can consider re-enabling the bulk import test that was skipped in https://github.com/redhat-developer/rhdh/pull/3105/files#diff-022a62fbf830a6fe2740f9e75c5cc80c7ae4e45a9f52b119002d9eb23be42a9f, to confirm that the tests pass with this PR?
Or are you planning to do this in a subsequent PR?

@dzemanov
Copy link
Member Author

@rm3l oh yeah, that needs to be reenabled, thank you for pointing it out. I will update this PR.

@openshift-ci openshift-ci bot removed the lgtm label Jul 24, 2025
Signed-off-by: Dominika Zemanovicova <[email protected]>
Copy link
Member

@rm3l rm3l left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link
Contributor

@PatAKnight
Copy link
Member

/retest

@dzemanov
Copy link
Member Author

e2e tests are detecting another error with Edit PR: https://issues.redhat.com/browse/RHDHBUGS-1908, I will have a fix for that soon and will update the wrapper in this PR.

Copy link

openshift-ci bot commented Jul 25, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: AndrienkoAleksandr, PatAKnight, rm3l

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Signed-off-by: Dominika Zemanovicova <[email protected]>
@openshift-ci openshift-ci bot removed the lgtm label Jul 25, 2025
Copy link

openshift-ci bot commented Jul 25, 2025

New changes are detected. LGTM label has been removed.

Copy link
Contributor

@dzemanov
Copy link
Member Author

/retest

Copy link

openshift-ci bot commented Jul 25, 2025

@dzemanov: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-tests 2bb1ee2 link true /test e2e-tests

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants