Initial support of PCP metrics gathering capability #72
Conversation
Adds "--use_pcp" option in general_setup Adds PCP infrastrucure including systemd service, default configs for pmlogger and openmetrics, commands and functions for use by wrappers, and sundries
|
This relates to RPOPC-517 |
| @@ -0,0 +1,134 @@ | |||
| #!/bin/bash | |||
| # Executed by systemd service 'PCPrecord.service' | |||
| pmlogger_running="false" # Initialize service as OFF | ||
| om_workload_file="/tmp/openmetrics_workload.txt" | ||
| om_workload_file_reset="/tmp/openmetrics_workload_reset.txt" | ||
|
|
There was a problem hiding this comment.
Files created in /tmp should use mktemp to avoid collisions. We do expect one workload one system at a time, but that may not always be the case. Not sure how pcp will behave in this type of situation.
| preaction=$(mark_ms) | ||
| case "${action_arr[0]}" in | ||
| Start) # 'Start $archive_dir $test_name $conf_file' | ||
| archive_dir="${action_arr[1]}" |
There was a problem hiding this comment.
have the case sections call a function when there is numerous lines involved.
Makes it easier to read the case statement.
There was a problem hiding this comment.
Agree in principle for larger blocks. However I wouldn't call any of these "numerous;" they're all 15 lines or less so in this case I'd like to keep them in place rather than add to the PgUp-ing and PgDn-ing.
| @@ -0,0 +1,131 @@ | |||
| FIFO="/tmp/pcpFIFO" | |||
| @@ -0,0 +1,131 @@ | |||
| FIFO="/tmp/pcpFIFO" | |||
There was a problem hiding this comment.
Use mktemp for the file please.
| @@ -0,0 +1,114 @@ | |||
| #!/bin/bash | |||
| # | ||
| # NOTE: use of these Functions require that PCP is already installed on the system | ||
| ################################################################################## | ||
|
|
There was a problem hiding this comment.
Indicate we will fail if not installed. We might want an explicit check for it.
| mkdir -p "${archive_dir}" | ||
|
|
||
| # Run PCP pmlogger | ||
| # JTH - VERIFY success, ensure pmlogger starts |
| echo "Timed out waiting for PMLOGGER to Start1" | ||
| exit 30 | ||
| fi | ||
| # Now check that PMLOGGER has started logging |
| # Stop PCP logger and pause for pmlogger to write archive | ||
| pkill -USR1 pmlogger | ||
| # Now check that PMLOGGER has stopped logging | ||
| timeout 5 bash -c \ |
There was a problem hiding this comment.
Is 5 seconds long enough? What happens if there is a lot of data queued up?
Description
This add initial PCP support to the common toolset for the "Zathras family" of workload wrappers as part of the migration from pbench
Before/After Comparison
Before: no Zathras-wide support for PCP
After: We have initial support for the use of PCP among the "Zathras family of wrapper"
Clerical Stuff
This closes #71
Relates to JIRA: RPOPC-517