Dont setup the ports until the docker container is being configured.#7
Closed
credmond-git wants to merge 1 commit intoredis-field-engineering:masterfrom
credmond-git:master
Closed
Dont setup the ports until the docker container is being configured.#7credmond-git wants to merge 1 commit intoredis-field-engineering:masterfrom credmond-git:master
credmond-git wants to merge 1 commit intoredis-field-engineering:masterfrom
credmond-git:master
Conversation
Author
|
Code has diverged greatly Closing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4
Before on the constructor it would call update, and this would add fixed exposed ports, locking in port 7000.
I removed the update in the constructor and moved it to the configure method inherited from
GenericContainer.When you start the docker container it calls the method
protected void configure()https://github.com/testcontainers/testcontainers-java/blob/3b7c2ebca73988b484a0bcdb339e7f04df016a41/core/src/main/java/org/testcontainers/containers/GenericContainer.java#L335
So we override the method and call update to setup the ports. This way we know everything has been set and we wont add any extra ports.