RI-8038 [E2E] 7.2 Settings -> Privacy Settings#5592
Open
Conversation
pd-redis
requested review from
ArtemHoruzhenko,
DimoHG,
KrumTy,
dantovska and
pawelangelow
as code owners
🛡️ Jit Security Scan Results
✅ No security findings were detected in this PR
Security scan by Jit
|
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 2 potential issues.
Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
redisinsight/ui/src/pages/browser/components/redisearch-key-list/RediSearchIndexesList.tsx
Outdated
Show resolved
Hide resolved
References: #RI-8038 Made-with: Cursor
pd-redis
force-pushed
the
e2e/RI-8038/privacy-settings
branch
from
8a34c78 to
ffc6852
Compare
KrumTy
previously approved these changes
Mar 9, 2026
valkirilov
reviewed
Mar 10, 2026
| @@ -666,9 +666,9 @@ The test plan is organized by feature area. Tests are grouped for parallel execu | |||
| ### 7.2 Privacy Settings | |||
Member
There was a problem hiding this comment.
Being in the context of an e2e test, does it make sense to actually verify whether we send (or don't) telemetry data, once we toggle the Usage data switch?
Like, a simple network interceptor, just to verify whether we emit send-page and send-event 🤔
The Section accordion from redis-ui renders headings, not buttons, for section labels. The collapse button has aria-label="Expand Section", not the section name. Updated isExpanded checks to use data-state on the accordion root element. Made-with: Cursor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Add Playwright E2E tests for the Privacy Settings section (7.2) of the Settings page.
Tests verify that the privacy section expands correctly, the usage data switch is displayed, and the privacy policy link is visible with the correct target attribute.
Testing
Run:
npx playwright test tests/main/settings/privacy-settingsCloses #RI-8038
Made with Cursor
Note
Low Risk
Test-only changes plus more robust UI selectors for accordion expansion state; minimal product risk, with minor risk of selector brittleness if settings DOM attributes change.
Overview
Adds Playwright E2E coverage for Settings → Privacy (7.2), validating the section expands and that the usage data toggle and privacy policy link (opens in a new tab) are visible.
Updates the
SettingsPagepage object to make accordion interactions more reliable by targeting section headings and determining expanded/collapsed state via each accordion’sdata-test-subj/data-stateattributes instead ofaria-expandedon buttons, and marks the 7.2 test cases as implemented inTEST_PLAN.md.Written by Cursor Bugbot for commit 241f9ca. This will update automatically on new commits. Configure here.