RI-8039 [E2E] 7.3 Settings -> Workbench Settings#5593
Open
Conversation
pd-redis
requested review from
KrumTy,
dantovska and
pawelangelow
as code owners
pd-redis
requested review from
ArtemHoruzhenko,
DimoHG and
valkirilov
as code owners
🛡️ Jit Security Scan Results
✅ No security findings were detected in this PR
Security scan by Jit
|
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
redisinsight/ui/src/pages/browser/components/redisearch-key-list/RediSearchIndexesList.tsx
Outdated
Show resolved
Hide resolved
References: #RI-8039 Made-with: Cursor
pd-redis
force-pushed
the
e2e/RI-8039/workbench-settings
branch
from
0bdc3f2 to
08bc78f
Compare
KrumTy
previously approved these changes
Mar 9, 2026
The Section accordion from redis-ui renders headings, not buttons, for section labels. The collapse button has aria-label="Expand Section", not the section name. Updated isExpanded checks to use data-state on the accordion root element. Made-with: Cursor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Add Playwright E2E tests for the Workbench Settings section (7.3) of the Settings page.
Tests verify that the editor cleanup switch and pipeline commands setting are displayed when expanding the Workbench section. The "Configure command timeout" test case is N/A (per-database setting, not on the Settings page).
Testing
Run:
npx playwright test tests/main/settings/workbench-settingsCloses #RI-8039
Made with Cursor
Note
Low Risk
Test-only changes plus selector adjustments in the Playwright page object; low impact outside E2E stability.
Overview
Adds Playwright E2E coverage for Settings → Workbench by asserting the editor cleanup switch and pipeline commands text are visible after expanding the section.
Updates the Settings page object to click accordion headings (instead of buttons) and to detect expanded state via
data-test-subj/data-stateattributes, making accordion interactions more robust. Marks the corresponding 7.3 items as implemented inTEST_PLAN.md.Written by Cursor Bugbot for commit c0ee55c. This will update automatically on new commits. Configure here.