RI-8040 [E2E] 7.4 Settings -> Redis Cloud Settings#5595
RI-8040 [E2E] 7.4 Settings -> Redis Cloud Settings#5595
Conversation
pd-redis
requested review from
ArtemHoruzhenko,
DimoHG,
dantovska,
pawelangelow and
valkirilov
as code owners
🛡️ Jit Security Scan Results
✅ No security findings were detected in this PR
Security scan by Jit
|
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
redisinsight/ui/src/pages/browser/components/redisearch-key-list/RediSearchIndexesList.tsx
Outdated
Show resolved
Hide resolved
Tests skip gracefully when cloudSso feature flag is disabled (browser mode). References: #RI-8040 Made-with: Cursor
pd-redis
force-pushed
the
e2e/RI-8040/redis-cloud-settings
branch
from
53eeb09 to
92ac960
Compare
| test.skip(true, 'Redis Cloud settings not available (cloudSso feature flag disabled)'); | ||
| } |
There was a problem hiding this comment.
we need a better way for such checks, the redisCloudButton could be hidden for electron and this will be skipped (false positive)
I was thinking about passing the environment when running tests somehow or relying on the playwright project
I have the same issue in my pr but didn't resolve it yet https://github.com/redis/RedisInsight/pull/5542/changes#diff-410bc7146336b19b7708fbcdee38b8a46991890d95d8cde6125fd53bbde13147R19-R22
…check Made-with: Cursor
2 participants
What
Add Playwright E2E tests for the Redis Cloud Settings section (7.4) of the Settings page.
Tests verify that the API user keys text, autodiscover button, and create cloud database button are displayed. Tests skip gracefully in browser mode when the
cloudSsofeature flag is disabled (Electron only).Testing
Run:
npx playwright test tests/main/settings/redis-cloud-settingsNote: Tests will be skipped in Chromium mode since the Redis Cloud section requires the
cloudSsofeature flag (Electron build only).Closes #RI-8040
Made with Cursor
Note
Low Risk
Test-only changes that add new E2E coverage and update documentation, with no production logic impact.
Overview
Adds new Playwright E2E coverage for the Settings page’s Redis Cloud section, asserting the
API user keystext plusAutodiscoverandCreate Redis Cloud databasebuttons are visible.Updates
TEST_PLAN.mdto mark the two Redis Cloud Settings cases as implemented, and makes the new suite auto-skip on non-Electron projects where thecloudSso-gated UI isn’t available.Written by Cursor Bugbot for commit 4494952. This will update automatically on new commits. Configure here.