Open
Conversation
Add Playwright E2E test verifying that enabling automatic data decompression persists after saving and reopening the edit dialog. References: #RI-8004 Made-with: Cursor
pd-redis
requested review from
ArtemHoruzhenko,
DimoHG,
dantovska,
pawelangelow and
valkirilov
as code owners
🛡️ Jit Security Scan Results
✅ No security findings were detected in this PR
Security scan by Jit
|
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
tests/e2e-playwright/tests/main/databases/decompression/decompression.spec.ts
Show resolved
Hide resolved
Added search functionality to the decompression E2E test to ensure the database can be located before editing. This improves the reliability of the test by confirming the database's presence prior to interaction. References: #RI-8004
KrumTy
previously approved these changes
Mar 9, 2026
valkirilov
reviewed
Mar 9, 2026
| | Status | Group | Test Case | | ||
| |--------|-------|-----------| | ||
| | 🔲 | main | Confirm setting a decompression type works | | ||
| | ✅ | main | Confirm setting a decompression type works | |
Member
There was a problem hiding this comment.
Does it make sense to actually verify decompression works?
- Seed some compressed keys in the database
- Connect to the database(as this test does right now)
- But also verify the keys are properly rendered later, in the Browser
Add compressor dropdown locator and select GZIP format so the decompression setting actually persists after save. References: #RI-8004 Made-with: Cursor
tests/e2e-playwright/pages/databases/components/AddDatabaseDialog.ts
Outdated
Show resolved
Hide resolved
Add E2E test that seeds GZIP-compressed data and verifies it renders correctly in the Browser with decompression enabled. Also add updateDatabase and Buffer support to ApiHelper. Made-with: Cursor
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
…om AddDatabaseDialog component
…and workspace facts to streamline documentation and improve clarity.
…ons parameter Removed the optional compressor parameter from the createDatabase method in ApiHelper to streamline the function and improve clarity.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Add Playwright E2E test for database decompression settings (TEST_PLAN.md section 1.8). Verifies that enabling automatic data decompression persists after saving and reopening the edit dialog.
Testing
npx playwright test tests/main/databases/decompression/decompression.spec.tswith local Redis instancesCloses #RI-8004
Made with Cursor
Note
Low Risk
Low risk: changes are confined to Playwright E2E test code and the test plan, with no production logic modifications.
Overview
Adds a new Playwright E2E spec covering database decompression: verifies selecting a compressor (e.g.,
GZIP) persists after saving/reopening the Edit Database dialog, and validates Browser displays decompressed string values for a seeded GZIP-compressed key.Extends E2E test utilities to support these scenarios by adding
ApiHelper.updateDatabase()(PATCH/api/databases/:id), allowing binary payloads increateStringKey(), and enhancingAddDatabaseDialogto select a compressor from the Decompression dropdown. UpdatesTEST_PLAN.mdto mark the decompression test as implemented.Written by Cursor Bugbot for commit 442ba78. This will update automatically on new commits. Configure here.