Open
Conversation
Add 2 Playwright E2E tests for certificate and encryption handling covering encryption enabled by default and disabling encryption via the EULA consent dialog, with API verification of settings. References: #RI-8003 Made-with: Cursor
pd-redis
requested review from
ArtemHoruzhenko,
DimoHG,
KrumTy,
dantovska,
pawelangelow and
valkirilov
as code owners
🛡️ Jit Security Scan Results
✅ No security findings were detected in this PR
Security scan by Jit
|
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
Added verification for the encryption toggle in the EULA consent dialog, ensuring the plain-text storage warning is displayed when encryption is disabled. Updated the test to check that the dialog is no longer visible after submission. References: #RI-8003
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Refactored the EULA acceptance method in the encryption handling tests for clarity and consistency. Removed redundant steps to re-enable encryption, streamlining the test flow. References: #RI-8003
Made-with: Cursor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Add 2 Playwright E2E tests for certificate and encryption handling (TEST_PLAN.md section 1.7). Tests verify that encryption is enabled by default in the EULA dialog and that disabling encryption stores the setting correctly via the API.
Tests run serially since they reset EULA agreements and re-accept after completion to restore clean state.
Testing
npx playwright test tests/main/databases/encryption/encryption.spec.tswith local Redis instanceCloses #RI-8003
Made with Cursor
Note
Medium Risk
Adds E2E tests that reset global EULA/agreements state via API, which can introduce flakiness or interference if other Playwright suites run against the same shared instance in parallel.
Overview
Implements Playwright E2E coverage for certificate/encryption handling by exercising the EULA consent popup’s encryption toggle.
The new spec resets agreements to force the EULA dialog, asserts encryption is enabled by default, verifies the plain-text storage warning when disabled, and confirms the resulting
agreements.encryptionvalue via the settings API. The test plan marks the two section 1.7 cases as completed.Written by Cursor Bugbot for commit 93fe65b. This will update automatically on new commits. Configure here.