Conversation
dantovska
requested review from
ArtemHoruzhenko,
DimoHG,
KrumTy,
pawelangelow,
pd-redis and
valkirilov
as code owners
🛡️ Jit Security Scan Results
✅ No security findings were detected in this PR
Security scan by Jit
|
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
| args: { | ||
| isOpen: true, | ||
| }, | ||
| } |
There was a problem hiding this comment.
Storybook stories missing required callback props
Medium Severity
Both stories (Default and WithoutPrefix) omit the required onConfirm and onCancel callback props. The PR description says this component is verified in Storybook, but clicking Continue, Cancel, or the close button will silently do nothing (or potentially error when onCancel is passed as undefined to S.ModalContent's onCancel prop). The sibling ViewIndexDataButton.stories.tsx correctly imports fn from storybook/test and provides it for callback args — the same pattern is missing here.
Code Coverage - Frontend unit tests
Test suite run success6360 tests passing in 760 suites. Report generated by 🧪jest coverage report action from ff0f57c |
1 participant
What
Add MakeSearchableModal — a confirmation modal shown before navigating users to the create index flow from the Browser page. It displays an illustration, explains that the user will be taken to the Search workspace, and optionally shows which key prefix will be indexed (e.g. "All keys starting with bicycle: will be included.").
Testing
Could be verified in storybook -
Pages/Browser/MakeSearchableModalNote
Low Risk
Low risk UI-only addition: introduces a new modal component with Storybook and unit tests, without modifying existing navigation, data, or auth flows.
Overview
Adds a new
MakeSearchableModalcomponent for the Browser page that prompts users before continuing to the Search/index-creation flow, optionally including a provided keyprefixin the description.Includes styled-components layout, Storybook stories (with/without prefix), and a Jest test suite covering open/close rendering and confirm/cancel/close callbacks.
Written by Cursor Bugbot for commit ff0f57c. This will update automatically on new commits. Configure here.