Open
Conversation
The vectorSearch flag is no longer used — all deprecated components that referenced it have been deleted. Clean up its definition from frontend and backend config/constants. Made-with: Cursor
valkirilov
changed the title
valkirilov
requested review from
ArtemHoruzhenko,
DimoHG,
KrumTy,
dantovska,
pawelangelow and
pd-redis
as code owners
🛡️ Jit Security Scan Results
✅ No security findings were detected in this PR
Security scan by Jit
|
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
redisinsight/ui/src/pages/browser/components/redisearch-key-list/RediSearchIndexesList.tsx
Show resolved
Hide resolved
Contributor
Code Coverage - Backend unit tests
Test suite run success3286 tests passing in 303 suites. Report generated by 🧪jest coverage report action from 2d6d123 |
Introduce the new vectorSearchV2 flag to re-gate all UI code that was previously behind dev-vectorSearch: routing, navigation, onboarding tour/features, BrowserPage index-panel redirect, and RediSearch indexes list. Remove stale TODO comments. Bump features-config version to 3.4 and enable the flag by default. Made-with: Cursor
valkirilov
force-pushed
the
feature/vector-search-v2-feature-flag-migration
branch
from
2d6d123 to
1d312c6
Compare
Contributor
Code Coverage - Integration Tests
|
Contributor
Code Coverage - Frontend unit tests
Test suite run success6352 tests passing in 759 suites. Report generated by 🧪jest coverage report action from 1d312c6 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Replace the old
vectorSearchanddev-vectorSearchfeature flags with a singlevectorSearchV2flag.vectorSearchflag is removed entirely, and all code previously gated bydev-vectorSearchis now gated byvectorSearchV2.Testing
vectorSearchV2is enabled and hidden when disabledNote
Low Risk
Low risk: this is primarily a feature-flag rename/consolidation affecting routing/navigation and onboarding flow, with no changes to data handling or auth. Main risk is misconfiguration causing the Search page/nav/onboarding step to appear or be skipped unexpectedly.
Overview
Consolidates Vector Search gating behind a single
vectorSearchV2feature flag across API and UI, removing the oldvectorSearch/dev-vectorSearchflags.Bumps
features-config.jsonversion to3.4and enablesvectorSearchV2by default; updates backend known-features/strategy wiring and switches UI route, nav menu, Browser "Create Index" redirect, and onboarding step skipping logic/tests to use the new flag.Written by Cursor Bugbot for commit 1d312c6. This will update automatically on new commits. Configure here.