Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

INT: modify default job example #1003

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

INT: modify default job example #1003

wants to merge 1 commit into from

Conversation

dwdougherty
Copy link
Collaborator

@dwdougherty dwdougherty commented Dec 19, 2024 •
edited by jira bot
Loading

@dwdougherty dwdougherty requested review from spicy-sauce and a team December 19, 2024 14:52
@dwdougherty dwdougherty self-assigned this Dec 19, 2024
@github-actions GitHub Actions
Copy link
Contributor

Staging links:
https://redis.io/docs/staging/DOC-4682/integrate/write-behind/data-transformation/data-transformation-pipeline

cmilesb
cmilesb approved these changes Dec 19, 2024
View reviewed changes
Copy link
Contributor

@cmilesb cmilesb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@dwdougherty
Copy link
Collaborator Author

Thank you, @cmilesb!

spicy-sauce
spicy-sauce requested changes Dec 22, 2024
View reviewed changes
content/integrate/write-behind/data-transformation/data-transformation-pipeline.md
@@ -38,12 +38,11 @@ default.yaml
```yaml
source:
table: "*"
row_format: full
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure if line 53 will still work if we remove it here, we probably should come up with a better example.
BTW, it also seems that this example is scaffolded in default.yaml.example, not sure if this ideal - @yaronp68

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did what was stated in the JIRA ticket. This will have to sit until @andy-stark-redis is back from PTO.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spicy-sauce spicy-sauce spicy-sauce requested changes

@cmilesb cmilesb cmilesb approved these changes

Requested changes must be addressed to merge this pull request.

Assignees

@andy-stark-redis andy-stark-redis

Labels
dev do not merge yet rdi
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dwdougherty @spicy-sauce @cmilesb @andy-stark-redis