Skip to content

DOC-5192 added C# production usage page #1491

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

andy-stark-redis
Copy link
Contributor

@andy-stark-redis andy-stark-redis commented May 2, 2025

DOC-5192

This is intended to give recommendations for production usage like the Jedis page, but it's actually quite difficult to find any advice for NRedisStack :-) (Client-side caching isn't implemented, and most of the stuff recommended for Jedis either happens by default or is handled automatically.)

I'd love to hear ideas - if we can't think of any more recommendations, then maybe this page isn't necessary for NRedisStack and we should just have a short section about this stuff in the landing page.

@andy-stark-redis andy-stark-redis requested a review from a team May 2, 2025 15:17
@andy-stark-redis andy-stark-redis self-assigned this May 2, 2025
Copy link
Collaborator

@dwdougherty dwdougherty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. One suggestion, though: can you use unique IDs for each checklist short code use? If you don't, then the stored status will apply to every page that uses the short code.

@andy-stark-redis
Copy link
Contributor Author

LGTM. One suggestion, though: can you use unique IDs for each checklist short code use? If you don't, then the stored status will apply to every page that uses the short code.

D'oh! Yeah, I completely forgot about that (I copied/pasted the top bit of the page, as you probably realised). I've fixed it now and I'll try to remember it for the remaining pages.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants