-
Notifications
You must be signed in to change notification settings - Fork 207
DEV: add generic-ish tab control #1651
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great - I just have one nit to pick. I'm definitely going to be using this in the future.
content/develop/multitabs-demo.md
Outdated
|
||
-tab-sep- | ||
|
||
## How to Use |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, @cmilesb! I appreciate the review.
I'm pretty sure the spacing issue is caused by heading padding. I removed the blank lines before and after -tab-sep- and the spacing stayed the same. Maybe don't use any headings in the tabs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was some extra padding being added in the CSS. I fixed that, but headings still cause a lot of extra top whitespace. I can't really do anything about that without really messing up our site.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fair enough, thanks for taking a look anyway.
DOC-5302
Adds a GitHub style tab element. This will be used in the command pages to provide separate containers for the RESP return information. This was requested by PM well over a year ago.
I will delete the multitabs-demo document before merging.