Skip to content

DEV: add generic-ish tab control #1651

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jun 3, 2025
Merged

DEV: add generic-ish tab control #1651

merged 5 commits into from
Jun 3, 2025

Conversation

dwdougherty
Copy link
Collaborator

@dwdougherty dwdougherty commented Jun 2, 2025

DOC-5302

Adds a GitHub style tab element. This will be used in the command pages to provide separate containers for the RESP return information. This was requested by PM well over a year ago.

I will delete the multitabs-demo document before merging.

@dwdougherty dwdougherty requested review from andy-stark-redis and a team June 2, 2025 21:13
@dwdougherty dwdougherty self-assigned this Jun 2, 2025
@dwdougherty dwdougherty added the ui label Jun 2, 2025
Copy link
Contributor

github-actions bot commented Jun 2, 2025

Staging links:
https://redis.io/docs/staging/DOC-5302/develop/multitabs-demo

Copy link
Contributor

@cmilesb cmilesb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great - I just have one nit to pick. I'm definitely going to be using this in the future.


-tab-sep-

## How to Use
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The spacing here doesn't look great. Does removing the blank line between the heading and the -tab-sep- line fix it, or is this just a hazard of heading padding?
Screenshot 2025-06-03 at 11 33 35

Copy link
Collaborator Author

@dwdougherty dwdougherty Jun 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @cmilesb! I appreciate the review.

I'm pretty sure the spacing issue is caused by heading padding. I removed the blank lines before and after -tab-sep- and the spacing stayed the same. Maybe don't use any headings in the tabs.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There was some extra padding being added in the CSS. I fixed that, but headings still cause a lot of extra top whitespace. I can't really do anything about that without really messing up our site.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fair enough, thanks for taking a look anyway.

@dwdougherty dwdougherty merged commit f3b5962 into main Jun 3, 2025
4 checks passed
@dwdougherty dwdougherty deleted the DOC-5302 branch June 3, 2025 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants