pull certificates from CA store on Windows, additionally to current Root system certificate store added with #889 #1235
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…oot system certificate store
masariello
changed the title
masariello
changed the title
Collaborator
|
Thanks for the PR. I can go through the code in the next couple of days but I don't have a Windows machine to verify that the logic works. |
Contributor
Author
|
No worries. It's quite tricky to test. But I did it at work and it did
solve the SSL cert verification I was having. And there are no other
relevant cert stores on WIndows. So this should be it.
Thank you
Il giorno lun 13 nov 2023 alle ore 23:53 Michael Grunder <
***@***.***> ha scritto:
… Thanks for the PR. I can go through the code in the next couple of days
but I don't have a Windows machine to verify that the logic works.
—
Reply to this email directly, view it on GitHub
<#1235 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABJ4PGDU3QVVVSCW2VTLI6DYEKXHFAVCNFSM6AAAAAA7BBHQOWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQMBZGMYTONRTGI>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#889 added support for pulling SSL certificates from the Root Windows certificate store. Turns out one actually needs both the Root and CA stores, so this adds the latter