[cmake] Fix cmake options position to support cmake toolchain #1250
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Greetings!
By declaring options in the CMake toolchain after the project() command in the CMakeLists.txt, you ensure that they are applied within the context of the project's environment, making them more coherent and ensuring that they override any default settings appropriately.
However, the current CMakeLists.txt declares
options()
first, beforeproject()
, which means, the context is not initialized and the options values from toolchain is ignored.The current scenario WITHOUT this PR:
cmake -S . -B build -DCMAKE_TOOLCHAIN_FILE=hiredis_toolchain.cmake
As you can see, the toolchain file is consumed, but CMake ignores its values.
In order to fix the current situation,
options()
should be moved afterproject()
.