Skip to content

Update minimum CMake version to 3.7 #1292

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 2, 2025

Conversation

uglide
Copy link
Contributor

@uglide uglide commented Apr 2, 2025

  • Require CMake 3.7 or newer
  • Test CMake build with 3.7, 3.22, 3.28 and 4.0

@uglide uglide requested a review from Copilot April 2, 2025 11:13
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the minimum required CMake version to 3.5 and adds a new GitHub Actions job to test the CMake build against multiple versions.

  • Add a new workflow job "test-cmake-version" with a matrix for CMake versions.
  • Test the build using CMake versions 3.5.0, 3.22.0, 3.28.0, and 4.0.0.
Files not reviewed (1)
  • CMakeLists.txt: Language not supported

@uglide uglide changed the title Update minimum CMake version to 3.5 Update minimum CMake version to 3.7 Apr 2, 2025
@uglide uglide force-pushed the bump_min_cmake_version branch from a34241e to 256f97e Compare April 2, 2025 11:52
- Require CMake 3.7 or newer
- Test CMake build with 3.7, 3.22, 3.28 and 4.0
Copy link
Contributor

@StefanPalashev StefanPalashev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks, @uglide!

Copy link
Collaborator

@michael-grunder michael-grunder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@michael-grunder michael-grunder merged commit 1387948 into redis:master Apr 2, 2025
15 checks passed
@uglide uglide deleted the bump_min_cmake_version branch April 3, 2025 08:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants