Change the version of the library to 1.3 #1296
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StefanPalashev
force-pushed
the
change-the-version-to-1.3
branch
2 times, most recently
from
b36e58a to
7cc7330
Compare
There was a problem hiding this comment.
I did some searching around and it seems like very few libraries actually define the SONAME in their headers like we do in hiredis.
Maybe the way to go is to drop the soname define in hiredis.h and just use the major version to construct the SONAME in both CMakeLists.txt and Makefile?
That said, I pulled this change and built hiredis and it works well, so if we don't want to remove the SONAME this change is fine with me.
StefanPalashev
changed the title
StefanPalashev
force-pushed
the
change-the-version-to-1.3
branch
from
7cc7330 to
e634eb1
Compare
uglide
requested changes
Apr 22, 2025
Change the CMakeLists.txt to produce a symlink with a generic name that points to the latest major version. The build output will now look like this: libhiredis.so -> libhiredis.so.1* libhiredis.so.1* -> libhiredis.so.1.3.0* libhiredis.so.1.3.0* This would allow for seamless minor version updates.
StefanPalashev
force-pushed
the
change-the-version-to-1.3
branch
from
e634eb1 to
f0271c6
Compare
uglide
approved these changes
Apr 23, 2025
|
All of the comments have been resolved by applying the suggested changes. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change the
CMakeLists.txtto produce a symlink with a generic name that points to the latest major version.The build output will now look like this:
This would allow for seamless minor version updates.