Skip to content

Implement string un/escaping and "raw" values #22

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Implement string un/escaping and "raw" values #22

wants to merge 2 commits into from

Conversation

@itamarhaber
Copy link
Member

@itamarhaber itamarhaber commented Jan 9, 2025 •
edited
Loading

  • Correctly handle quoted and/or escaped input string arguments
  • Correctly display nonprintable and whitespace binary string values
  • Correctly distinguish (UI) between "simple" and "binary" strings (i.e., no quotes or with quotes)
  • Correctly handle "raw" outputs from whitelisted commands (i.e., INFO and CLIENT LIST)

Fixes #18
Fixes #20

@itamarhaber
Fixes:
6b4382f 
* Correctly handle quoted and/or escaped input string arguments
* Correctly display nonprintable and whitespace binary string values
* Correctly distinguish (UI) between "simple" and "binary" strings (i.e., no quotes or with quotes)
benoitdion
benoitdion reviewed Jan 10, 2025
View reviewed changes
interwebz/static/js/cli.js Outdated
@@ -1,4 +1,4 @@
const API_URL = 'https://cli.redis.io',
const API_URL = 'http://localhost:5000',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

revert?

itamarhaber
itamarhaber commented Jan 10, 2025
View reviewed changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@benoitdion benoitdion benoitdion left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

BITPOS Wrong examples results BITPOS example is incorrect

2 participants

@itamarhaber @benoitdion